Ticket #10604 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

IDR: Calibration breaks when loading IRIS runs with new format

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: critical Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: franz.demmel@… Blocked By: #10571
Blocking: Tester: Federico M Pouzols

Description (last modified by Dan Nixon) (diff)

When loading an IRIS (and by assumption OSIRIS) run with the new filename format (i.e. IRIS0001234.raw), the energy plot is not shown and an exception is thrown.

Attachments

IRIS00063880.raw​ (243.0 KB) - added by Dan Nixon 6 years ago.
Sample file for testing
IRIS00063830.raw​ (243.0 KB) - added by Dan Nixon 6 years ago.
An addition file

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned
  • Milestone changed from Backlog to Release 3.3

comment:2 Changed 6 years ago by Dan Nixon

  • Description modified (diff)
  • Blocked By 10571 added

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Merge branch 'bugfix/10571_indirect_algoritm_output_properties' into bugfix/10604_idr_calib_new_run_numbers

Refs #10604

Changeset: 2286090fc4d1f04766389b282c46c3294058e650

comment:4 Changed 6 years ago by Dan Nixon

Fix preview plots on Calib and Diag

Refs #10604

Changeset: 24bca022cff2b5545f2cf12099f65a6b10cfe63f

comment:5 Changed 6 years ago by Dan Nixon

  • Cc franz.demmel@… added

comment:6 Changed 6 years ago by Dan Nixon

(also noticed Diagnostics had the same problem, also fixed)

To test:

  • Load the sample file into Indirect > Data Reduction > Calibration
  • The raw plot and energy plot should both be plotted
  • Load it into Diagnostics
  • The raw and preview plots should both be plotted

Changed 6 years ago by Dan Nixon

Sample file for testing

comment:7 Changed 6 years ago by Dan Nixon

Merge branch 'master' into bugfix/10604_idr_calib_new_run_numbers

Refs #10604

Changeset: f28e7cf238c5f33c821d46dfba2f75a4ae209d25

Changed 6 years ago by Dan Nixon

An addition file

comment:8 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:9 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:10 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

It works, there's no exception anymore, the plots are shown and they look reasonable.

comment:11 Changed 6 years ago by Dan Nixon

Merge branch 'bugfix/10571_indirect_algoritm_output_properties' into bugfix/10604_idr_calib_new_run_numbers

Refs #10604

Full changeset: ​2286090fc4d1f04766389b282c46c3294058e650

comment:12 Changed 6 years ago by Dan Nixon

Merge branch 'master' into bugfix/10604_idr_calib_new_run_numbers

Refs #10604

Full changeset: ​f28e7cf238c5f33c821d46dfba2f75a4ae209d25

comment:13 Changed 6 years ago by Federico Montesino Pouzols

Merge remote-tracking branch 'origin/bugfix/10604_idr_calib_new_run_numbers'

Full changeset: ​c456cea773e493f79131b13cf113dc720dc30566

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11446

Note: See TracTickets for help on using tickets.