Ticket #11755 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Generate .py from .ui files as part of the build

Reported by: Nick Draper Owned by: Owen Arnold
Priority: major Milestone: Release 3.5
Component: Tools Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Currently this is an ugly manual process, make it work as well as it curently does for C++ ui files

Change History

comment:1 Changed 5 years ago by Owen Arnold

  • Status changed from new to inprogress

refs #11755. CMake function and find module.

Changeset: e032b29483a7a73268f43eae83fd08804f428408

comment:2 Changed 5 years ago by Owen Arnold

refs #11755. Ignore ui files autogenerated.

Changeset: 9eeaff3d8d51e575d5c05c72b644b0e8f38d3c41

comment:3 Changed 5 years ago by Owen Arnold

refs #11755. Reflectometry GUI files.

Changeset: a19e070cc4edc7a713720e00fe987e4f5c3f3bc6

comment:4 Changed 5 years ago by Owen Arnold

refs #11755. Reflectometry UIs.

Changeset: c6a663304577e9462cd77d6392cdbc6796db0fac

comment:5 Changed 5 years ago by Owen Arnold

refs #11755. Sans UI.

Changeset: fffce74f4462d2a0295245950b32bee2913d939a

comment:6 Changed 5 years ago by Owen Arnold

refs #11755. Diffraction UI.

Changeset: 5e014be216b7cc9a8504e9eada65adca6a53d864

comment:7 Changed 5 years ago by Owen Arnold

refs #11755. Inelastic UI.

Changeset: f2eb43628f0ca485a6e40627483de697596f6256

comment:8 Changed 5 years ago by Owen Arnold

refs #11755. PyChop UI.

Changeset: 79c8a7ea9d298195edebe3343d622de7e28323d1

comment:9 Changed 5 years ago by Owen Arnold

refs #11755. FilterEvents Ui.

Changeset: d16ac0fc14c2d831df98b8320be86c29b243d155

comment:10 Changed 5 years ago by Owen Arnold

refs #11755. HFIRPowderReduction Ui.

Changeset: 3b277bef7f03c263730d6a9e04ae7f9b84e39c4a

comment:11 Changed 5 years ago by Owen Arnold

refs #11755. lib1to2 UI.

Changeset: e2d4e12a4c719c7647a3984168c99294935899f5

comment:12 Changed 5 years ago by Owen Arnold

refs #11755. TofConverter Ui.

Changeset: 7347f8cb425264818aa849fee3295ebec43f2417

comment:13 Changed 5 years ago by Owen Arnold

refs #11755. ui dir files.

Changeset: a5b10be3931a892e822d9c9f7677116dbb752559

comment:14 Changed 5 years ago by Owen Arnold

refs #11755. Exclude cmakelists from install.

Changeset: 4d39db04f1f3838b788c72235840dc9b9ad73f88

comment:15 Changed 5 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #800.

comment:16 Changed 5 years ago by Owen Arnold

Still need to sort out Pylint ignores

comment:17 Changed 5 years ago by Owen Arnold

refs #11755 use custom targets and fixup

Make py files from ui files during the build step not during cmake configuration Start introducing custom targets under the umbrella CompileUI and set as a dependency on MantidPlot Fix up the python scripts during the conversion so that they can be ignored by pylint

Changeset: 8a86759857bfde83aa34f1e99abf5f0216880501

comment:18 Changed 5 years ago by Owen Arnold

refs #11755. Convert remaining uis.

Small change to target name.

Changeset: e083c018c3a841a4755aa05f6226da2b0cad99c7

comment:19 Changed 5 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:20 Changed 5 years ago by Martyn Gigg

I can see that the system test failure is CalibrateRectangularDetector_Test.PG3Calibration, which was broken on master at the time this pull request was opened. This has since been fixed and the changes are nothing to do with the .ui files changes here

comment:21 Changed 5 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge pull request #800 from mantidproject/11755_ui_to_py

Python ui to pyqt4 py modules

Full changeset: ​aaf558e4d15672993eb9d9ba4832d1a45e9fc1a0

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12593

Note: See TracTickets for help on using tickets.