Sort out the CurveFitting function declarations that are causing Intel compiler warnings

[Russell Taylor]

The methods are function, functionDeriv, calJacobianForCovariance & removeTie. They have different signatures in different classes in the inheritance heirarchy, so those in the base classes are being hidden, triggering the warning.

The warnings can be seen by going to ​http://download.mantidproject.org/jenkins/view/ISIS%20clean%20builds/job/isis_clean_snowleopard_systemtested/warnings and looking at the warnings listed in the API, CurveFitting and MDAlgorithms source folders.

[Russell Taylor]

In [13166]:

Clear Intel compiler warning. Re #3352.

[Roman Tolchenov]

In [13179]:

Hoping to fix some warnings. re #3352

[Roman Tolchenov]

In [13181]:

Fixing the error. re #3352

[Russell Taylor]

Thanks for looking at this Roman. There are just 3 related warnings left now:

/Users/tr9/Mantid/Code/Mantid/Framework/CurveFitting/inc/MantidCurveFitting/BivariateNormal.h(144): warning #1125: function "Mantid::API::IBackgroundFunction::fit(const std::vector<double, std::allocator<double>> &, const std::vector<double, std::allocator<double>> &)" is hidden by "Mantid::CurveFitting::BivariateNormal::fit" -- virtual function override intended?

void fit( std::vector<double> , std::vector<double>);

/Users/tr9/Mantid/Code/Mantid/Framework/CurveFitting/inc/MantidCurveFitting/Gaussian.h(69): warning #1125: function "Mantid::API::IFunctionMW::calJacobianForCovariance(Mantid::API::Jacobian *, const double *, const int &)" is hidden by "Mantid::CurveFitting::Gaussian::calJacobianForCovariance" -- virtual function override intended?

virtual void calJacobianForCovariance(API::Jacobian* out, const double* xValues, const size_t nData);

/Users/tr9/Mantid/Code/Mantid/Framework/CurveFitting/inc/MantidCurveFitting/Resolution.h(54): warning #1125: function "Mantid::API::IFunctionMW::functionDerivMW(Mantid::API::Jacobian *, const double *, size_t={darwin_size_t={unsigned long}})" is hidden by "Mantid::CurveFitting::Resolution::functionDerivMW" -- virtual function override intended?

void functionDerivMW(API::Jacobian* out, const double* xValues, const size_t nData)const

[Roman Tolchenov]

In [13261]:

Clearing warnings. re #3352

[Russell Taylor]

In [13277]:

Clear last remaining Intel warnings related to CurveFitting. Fixes #3352. Clear some other Intel warnings as well. Re #3302.

[Russell Taylor]

All the warnings discussed here are long gone.

[Stuart Campbell]

This ticket has been transferred to github issue ​4199