Ticket #3717 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

tcmalloc should be a hard dependency on Linux

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

Now that we have it available on all out supported platforms, we should make it mandatory (or at least on by default) - at the moment you only get a message that's easy to miss if you don't have it installed.

Change History

comment:1 Changed 9 years ago by Russell Taylor

In [14653]:

Make it harder to not be using tcmalloc without realising it. Re #3717.

comment:2 Changed 9 years ago by Russell Taylor

In [14655]:

Make sure the message gets out. Re #3717.

comment:3 Changed 9 years ago by Russell Taylor

In [14661]:

Clarification message. Re #3717.

comment:4 Changed 9 years ago by Russell Taylor

  • Status changed from new to accepted
  • Owner set to Russell Taylor

comment:5 Changed 9 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

I think this is as far as we want to go with this. You now get a failure the first time you run CMake if you don't have tcmalloc, but a message tells you what to do to turn it off.

Particularly given the fact that the default Ubuntu 10.04 google-perftools is broken (you have to get it from the ISIS repo instead), we shouldn't make it an absolute requirement.

comment:6 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:7 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

I remember seeing the build failures on Jenkins when this was rolled out (before TCmalloc was installed there).

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4564

Note: See TracTickets for help on using tickets.