Ticket #3860 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Paraview: crash if entering bad values in Rebinning filter

Reported by: Janik Zikovsky Owned by: Owen Arnold
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

  • Load any MDWorkspace
  • Add the Mantid Rebinning filter
  • Say for example that the Z binning min = -10 and max = +10
  • Type in for example +15 (more than max) in the "Min" box.
  • Tab or click away
  • Crash 
terminate called after throwing an instance of 'std::invalid_argument'
  what():  setRange: wrong argument

Change History

comment:1 Changed 9 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Owen Arnold

In [15113]:

refs #3860. Should fix the issue and provide UI message when parameters of min & max are used incorrectly.

comment:3 Changed 9 years ago by Owen Arnold

In [15114]:

refs #3860. Changes to concrete dimension type delivered by factory caused failing test.

comment:4 Changed 9 years ago by Owen Arnold

In [15117]:

refs #3860. Recover dimension range overriding, while keeping ability to check and handle errors.

comment:5 Changed 9 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester should try putting invalid ranges into the min and max boxes. For example min = 10, max = 5. Contact Owen Arnold if you would like to access some demo data.

comment:6 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:7 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

Putting in silly values for the min,max ranges is now trapped by the program and it does not crash.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4707

Note: See TracTickets for help on using tickets.