CovertMatrixtoMD algorithm

[Nick Draper]

Write an algorithm that will copy a matrix workspace to a 2 dimensional MD workspace. No unit or axis conversion is required.

The aim of this is to allow workspaces from SOFQW2 to be viewed in the sliceviewer, but it would be nice if it worked for any 2D workspace if possible.

[Alex Buts]

refs #4572 changes to default values caused by bug ref #4590

Allows to use algorithm from GUI until the bug is fixed.

Changeset: 089842d0f704cd32062709ea618a917b0171aa58

[Alex Buts]

refs #4572 Changed Box-controller validators to accept values from 1

apparently this is needed for correct box controller operations.

Changeset: d0c178ef3617752a40771e8291ec68501d6e96d7

[Alex Buts]

refs #4572 This fixes it

Though ConvertToMDEvents was copying data to target ws before, some processed ws which did not have detector information attached to it were empty as no spectra-det map was present (equal to empty spectra-det map)

Solved by generating fake 1:1 spectra detector map to fake detectors (which were and are not used)

Couple more tests are needed to validate the code

Changeset: 6ea40c2fd55900065cbe205e64b6e1aa168f27c9

[Alex Buts]

refs #4572 Some unit tests for new behavior.

checks if the detector lost info propagates properly.

Changeset: 0e8f47f7b2088ed3d9985f3344f5a62a47fc7d97

[Alex Buts]

COnvertToMDEvents has the requested behaviour. Simple python script below illustrates this, though seeing bigger input workspace (e.g. converted to energy MARI) is more persuasive.

Should work for any 2D matrix or Event ws too.

Load(Filename='IRS26173_ipg.nxs',OutputWorkspace='IRI_ipg') SofQW2(InputWorkspace='IRI_ipg',OutputWorkspace='IRI',QAxisBinning='0.5,0.25,2',EMode='Indirect',EFixed='1.8400000000000001') ConvertToMDEvents(InputWorkspace='IRI',OutputWorkspace='MD_IRI',QDimensions="",dEAnalysisMode="",MinValues='0,-1',MaxValues='2,2',SplitInto="200,200") plotSlice("MD_IRI", xydim=["Q1","Q2"], slicepoint=[0,0] )

[Alex Buts]

refs #4572 Minor changes to comments

Changeset: 729a63770120dc12adf36c962a9f37d3daf7991a

[Janik Zikovsky]

OK this works as described above for the result of SofQW2. However, going to a MDEventWorkspace causes some issues when rebinning later (Jon Taylor raised these).

A better solution will be addressed in ticket #4666 and #4665.

[Janik Zikovsky]

I missed one issue: the dimensions in the output MD workspace have no names, units or IDs. This needs to be fixed for this iteration.

[Alex Buts]

refs #4572 Creates dimID-s if they have not been copied

from source workspace (appears empty)

Changeset: c269ce50ddf372c84c48c825a815fdb83e661796

[Alex Buts]

refs #4572 Created default dimID if input are empty

If input ws provides empty dim ID-s the algorithm creates default dimID-s (Dim0,Dim1, etc) Dim-names should be copied from source workspace.

Changeset: a0d786270e5b5c6b44877afce349c1d8195e82b6

[Alex Buts]

ideally algorithm should copy dimNames and dim ID-s from input workspace axis. It is what it is hopefully doing with dim-names. No ID-s specified.

I've added small piece of code, which should generate default dimension's ID (Dim0, Dim1 etc) if neither ID nor dim-names are present along axis of input ws.

Ideally, SofQ should copy names and Id=s from axis of the source ws -- something to Martin to look at if he deals with SofQ

[Janik Zikovsky]

Can we get the dimension name to be the same as the ID in the case of the default Dim0 etc.?

[Alex Buts]

refs #4572 DimName=DimID if DimName is initially empty

Changeset: 31ce5ea84fa49d66bdeabc4099c35f98ff8ed9c0

[Alex Buts]

refs #4572 DimID is not empty in any mode

not only in NoQ as before

Changeset: 59409a1fd1d50cc8f2a3ea9f6acb8f73905cb13b

[Alex Buts]

refs #4572 Actually, DimNames not empty in any mode too.

Changeset: b7512cabec5782bad9f271cf7a626dd82c424fb0

[Janik Zikovsky]

Dimensions have names now.

[Stuart Campbell]

This ticket has been transferred to github issue ​5419