[C2E] - New Indirect "Transmission" Tab

[Peter Parker]

Attached files are from Spencer to show what is needed in this tab.

It's fairly straight forward but needs to be changed so that the monitor spectrum ID numbers are taken from the Instrument definition file. There are 2 monitors:

• Incident_monitor normally spectrum 1.
• Transmission_monitor normally spectrum 2.

[Peter Parker]

Refs #4889 - Added files to be used in new tab.

Changeset: 5330f1fe11329b52af30fed43633ed834cd6f4aa

[Nick Draper]

Moved at end of release 2.1

[Nick Draper]

Moved at the end of release 2.2

[Peter Parker]

Update:

This is an ongoing ticket. Similarly to Bayes /ForCE / etc., need further info from Spencer to proceed. Relevant files were committed in comment 1.

[Nick Draper]

Moved to milestone 2.4

[Nick Draper]

Moved to r2.6 at the end of r2.5

[Nick Draper]

Moved to backlog at the code freeze for R2.6

[Samuel Jackson]

Added new interface and skeleton code for Transmission tab.

Refs #4889

Changeset: d47d4f34053e56af2a41a4eca9a9bd831b4ee198

[Samuel Jackson]

Linked interface with algorithm

Refs #4889

Changeset: eb567252e4d2eaf6265b5540a29f58fa87e4d19d

[Samuel Jackson]

Merge remote-tracking branch 'origin/master' into feature/4889_indirect_transmission_tab

Conflicts:

Code/Mantid/Framework/PythonAPI/PythonAlgorithms/WorkflowAlgorithms/IDAtransmission.py

Refs #4889

Changeset: 5276b903dbb04ccdbe897b299145c06d3c26330e

[Samuel Jackson]

Output now includes run number in name.

Refs #4889

Changeset: 03e7e4a619b5c9a2b59708a727a27865a563293d

[Samuel Jackson]

Fixed options in new python API.

Also added better error checking.

Refs #4889

Changeset: b11997a5bff133117cd0e7a0b9cb6879d594e0c1

[Samuel Jackson]

Adding more verbose python output

Refs #4889

Changeset: 526e9720b9c6979e4e183bb100d20028d4a100e4

[Samuel Jackson]

Moved options to bottom of tab.

Also changed index of tab to be before S of Q

Refs #4889

Changeset: d32e6f69c2902f6ab88be1fa6c8df82dfb61f5ca

[Samuel Jackson]

Removed IDAtransmission algorithm from application.

Refs #4889

Changeset: e459d7e7f994426c9faf5cc4f3985d1d9b57b506

[Samuel Jackson]

Modifying python code to directly use function

Refs #4889

Changeset: 14b029fea33242225b220b3fd2135c34580958f2

[Samuel Jackson]

Minor cosmetic change to interface re Spencer.

Refs #4889

Changeset: f90cedd6c35998ca75918c8591f5deb826271f39

[Samuel Jackson]

To Test

The C2E interface has a new tab called Transmission. Use the supplied .raw files as input and check that the results produced are reasonable. This tab is designed to replace the IDATransmission algorithm, so I suggest running the input through that first to get a reference result then checking it against the output of the tab. Also check that the verbose, plot, and save options work correctly.

[Samuel Jackson]

Example Sample file

[Samuel Jackson]

Example Can file

[Michael Reuter]

The provided reference scripts don't run since they are using the version 1 API. It maybe they just don't work at all. I get the following error.

Error in execution of algorithm IDAtransmission:
Python error: 'tuple' object has no attribute 'getPropertyValue'
  at line 30 in '/home/2zr/data/Mantid/UserAlgorithms/IDAtransmission.py'
  caused by line 53 in '/home/2zr/data/Mantid/UserAlgorithms/IndirectTrans.py'
  caused by line 31 in '/home/2zr/data/Mantid/UserAlgorithms/IndirectTrans.py'
  caused by line 12 in '/home/2zr/data/Mantid/UserAlgorithms/IndirectTrans.py'

without the reference data, it's going to be hard to see if things got translated properly.

On the new tab, it seems that the Verbose option does nothing. I get lots of output in the results log no matter what state it is in.

[Samuel Jackson]

Script to generate a reference result

[Samuel Jackson]

The python scripts supplied with this ticket were not supposed to be used as reference result scripts for testing. They have been integrated into Mantid and ported to the new version of the API as part of ticket #7760 and then linked with the GUI as part of this ticket.

I've attached a slightly modified version of the original indirect trans script that can be used to generate a reference result. I ran CheckWorkspacesMatch on each of the corresponding child workspaces and they appeared to match.

The verbose option is working, but it isn't supposed to remove all the output from the console . It just stop certain parts of the python script printing out. For example with verbose checked the algorithm should print "Transmission : 0.79530004532" as the second to last line of the results log. However, I agree that the usefulness of this option is somewhat debatable.

[Michael Reuter]

It all looks like it checks out now.

[Michael Reuter]

Merge remote-tracking branch 'origin/feature/4889_indirect_transmission_tab'

[Stuart Campbell]

This ticket has been transferred to github issue ​5735