Ticket #4996 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

LoadDetectorsGroupingFile does not use same XML format as GroupDetectors

Reported by: Stuart Campbell Owned by: Wenduo Zhou
Priority: critical Milestone: Release 2.1
Component: Mantid Keywords:
Cc: nick.draper@…, pf9@… Blocked By:
Blocking: Tester: Jose Borreguero

Description (last modified by Stuart Campbell) (diff)

The XML grouping file format that is accept by the routines GroupDetectors (older) and LoadDetectorsGroupingFile are different.

We really should only need one format.

(I don't mean that we can't extend the format - but the 'base' should be the same)

Change History

comment:1 Changed 9 years ago by Stuart Campbell

  • Description modified (diff)

comment:2 Changed 9 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Wenduo Zhou

Support old XML format. Refs #4996.

(1) Make LoadDetectorsGroupingFile to support grouping file in 'old' xml format. (2) Refactor the codes to make load XML to be an independent class.

Changeset: 2828591892e027f48af4377e25d95ce79d4d201b

comment:4 Changed 9 years ago by Wenduo Zhou

Make to support new XML format. Refs #4996.

(1) GroupDetectors2 is enabled to support grouping file in 'new' XML format. (2) Original XML parser class is removed and replaced by the XML class used by LoadDetectorsGroupingFile().

Changeset: 4c64657dc57300bc2bab89f01138d66d2ac6978e

comment:5 Changed 9 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 8 years ago by Jose Borreguero

  • Status changed from verify to verifying
  • Tester set to Jose Borreguero

comment:7 Changed 8 years ago by Jose Borreguero

  • Status changed from verifying to closed

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5842

Note: See TracTickets for help on using tickets.