Ticket #5596 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

NormaliseByCurrent not multi-period fix

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

It's more robust to have a check for nperiods > 1 than nperiods > 0 because some workspaces store the nperiods even when it is not multi-period data.

This is a fix to the original #5576 ticket. Recently highlighted by failing system tests.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Owen Arnold

refs #5596. Fix applied and tested

Changeset: 10649f972c55cfda69f46b828c4d0a10b7e0e539

comment:3 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: This is a very simple fix, see changeset. Unit tests have been added to exercise the fix.

comment:4 Changed 8 years ago by Owen Arnold

refs #5596. Fix applied and tested

Changeset: 10649f972c55cfda69f46b828c4d0a10b7e0e539

comment:5 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:6 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

This seems to be working correctly.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6442

Note: See TracTickets for help on using tickets.