Ticket #5656 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Code review changes for ConvertToMD

Reported by: Nick Draper Owned by: Alex Buts
Priority: critical Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

Some points that were raised at the code review:

  • Replace usage of Auto_ptr with scoped_ptr or shared_ptr
  • Refactor the ConvertToMD->exec method into subfunction (no more than a screen long)
  • Update the UML diagram to also include the ConvertToMD algorithm
  • Create a wiki page aimed at developers (in the development category), with the class diagram and a text desription of the responsibilities of each major class. Link to it from the doxygen and algorithm help page.
  • Adjust code style as suggested by Martyn Gigg's earlier review. (indent, braces, variable naming)

Change History

comment:1 Changed 8 years ago by Alex Buts

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Alex Buts

  • Blocking 5553 added

This ticket is the extension of ticket 5553 so should be treated together.

comment:3 Changed 8 years ago by Alex Buts

  • Blocking 5553 removed

(In #5553) These changes are mainly complete except spaces between equal sing.

Bearing in mind ticket #5656 and appalling performance of this code, which will request substantial changes anyway, I am closing this ticket and transferring remain change to ticket #5656

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:5 Changed 8 years ago by Alex Buts

refs #5656 Got rid of std::auto_ptr

Changeset: 6310d27bdcf22f309f1124155e04b4963976237f

comment:6 Changed 8 years ago by Alex Buts

refs #5656 Minor changes related to algorithm description.

Changeset: 328734e18a2cd9c72d8086d84adf8be7de312722

comment:7 Changed 8 years ago by Alex Buts

refs #5656 Make property description equal to web version

Changeset: f9f4f95d0a827c0af8c4798fc1c90c0f58771f85

comment:8 Changed 8 years ago by Alex Buts

refs #5656 Refactored the ConvertToMD->exec method into subfunctions

(no more than a screen long). This almost it, the remaining is in preprocessing detectors which have a ticket of its onw,

Changeset: 50bbdd9364dc68a63e21e82bfe7b347691510414

comment:9 Changed 8 years ago by Alex Buts

refs #5656 bugfix and minor corrections according to the requests

Changeset: 35fbffe4a5c17426ac216bf42c7c4404f59ae73d

comment:10 Changed 8 years ago by Alex Buts

It is hopefully done.

The tester should look both at code and at the description and check if he understands what it is all about.

comment:11 Changed 8 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:12 Changed 8 years ago by Alex Buts

refs #5656 minor modifications to ConvertToMD.zargo

show unit conversion too

Changeset: a17e5f2d112d5d171153fd49a6580f84ce3a86a9

comment:13 Changed 8 years ago by Alex Buts

refs #5656 Minor changes to the class diagram.

Changeset: 30d162ca283b31e9a694baa3d597aff90be560c4

comment:14 Changed 8 years ago by Alex Buts

refs #5656 Got rid of std::auto_ptr

Changeset: 6310d27bdcf22f309f1124155e04b4963976237f

comment:15 Changed 8 years ago by Alex Buts

refs #5656 Minor changes related to algorithm description.

Changeset: 328734e18a2cd9c72d8086d84adf8be7de312722

comment:16 Changed 8 years ago by Alex Buts

refs #5656 Make property description equal to web version

Changeset: f9f4f95d0a827c0af8c4798fc1c90c0f58771f85

comment:17 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

accepted

comment:18 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed

comment:19 Changed 8 years ago by Alex Buts

refs #5656 Refactored the ConvertToMD->exec method into subfunctions

(no more than a screen long). This almost it, the remaining is in preprocessing detectors which have a ticket of its onw,

Changeset: 50bbdd9364dc68a63e21e82bfe7b347691510414

comment:20 Changed 8 years ago by Alex Buts

refs #5656 bugfix and minor corrections according to the requests

Changeset: 35fbffe4a5c17426ac216bf42c7c4404f59ae73d

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6502

Note: See TracTickets for help on using tickets.