Ticket #5678 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Create workflow algorithm for DGS detector diagnostics

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

A new workflow algorithm needs to be created that will perform the necessary setup and run DetectorDiagnostic.

Change History

comment:1 Changed 8 years ago by Michael Reuter

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Michael Reuter

Refs #5678. Initial checkin.

Changeset: c0949e2aec3449048a24c28219e9dd81a9fa68e5

comment:3 Changed 8 years ago by Michael Reuter

Refs #5678. Setup work done. Now to test.

Changeset: cc243889f54221552936f11053118e78c71c2103

comment:4 Changed 8 years ago by Michael Reuter

Refs #5678. Fixes to get things working (not yet).

Changeset: baffaeef745460d8531888a9fb865dae2ebb50ff

comment:5 Changed 8 years ago by Michael Reuter

Refs #5453, #5623, #5655 and #5678. Major changes.

I had to a lot of major changes to stop workspaces from getting stomped on. I had to turn off reliance on the ADS and pass workspace pointers around by hand to keep things separated.

Changeset: 346d66e4d08660082560658249d72915946d71ea

comment:6 Changed 8 years ago by Michael Reuter

Refs #5678. Clearing some workspaces.

Changeset: aef14a7221d070b999c87f7ed7b57de18e345b4f

comment:7 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:8 Changed 8 years ago by Michael Reuter

Refs #5678. Initial checkin.

Changeset: c0949e2aec3449048a24c28219e9dd81a9fa68e5

comment:9 Changed 8 years ago by Michael Reuter

Refs #5678. Setup work done. Now to test.

Changeset: cc243889f54221552936f11053118e78c71c2103

comment:10 Changed 8 years ago by Michael Reuter

Refs #5678. Fixes to get things working (not yet).

Changeset: baffaeef745460d8531888a9fb865dae2ebb50ff

comment:11 Changed 8 years ago by Michael Reuter

Refs #5453, #5623, #5655 and #5678. Major changes.

I had to a lot of major changes to stop workspaces from getting stomped on. I had to turn off reliance on the ADS and pass workspace pointers around by hand to keep things separated.

Changeset: 346d66e4d08660082560658249d72915946d71ea

comment:12 Changed 8 years ago by Michael Reuter

Refs #5678. Clearing some workspaces.

Changeset: aef14a7221d070b999c87f7ed7b57de18e345b4f

comment:13 Changed 8 years ago by Michael Reuter

Refs #5453 and #5678. Renaming parameters.

Changeset: 01ecbd7596dae7a787457ba6edc595ea299b81b6

comment:14 Changed 8 years ago by Michael Reuter

Refs #5453 and #5678. Forgot some parameters.

Changeset: 57a6329036006b9f32141a943271442d9ec8f86a

comment:15 Changed 8 years ago by Michael Reuter

Refs #5678. Changes to get things working.

comment:16 Changed 8 years ago by Michael Reuter

Refs #5678. Fix Mac build.

Changeset: 88fa1a8c0569654f541f086d10f32f7a905fc96a

comment:17 Changed 8 years ago by Michael Reuter

Refs #5678. Another attempt at Mac/Windows fix.

Changeset: 77ca62bf052d3b3074e648c40d616e4a82d53974

comment:18 Changed 8 years ago by Michael Reuter

Refs #5678. Another attempt at Mac/Windows fix.

Changeset: ccbbc6858d82c349dd68d0f9e962650f112e9cf9

comment:19 Changed 8 years ago by Michael Reuter

Refs #5678. Temporary fix to make WinXP happy.

Changeset: 585017026382a73e902f3a6f834ddd5037090fb4

comment:20 Changed 8 years ago by Michael Reuter

Refs #5678. Fix to make Windows XP happy for time being.

Changeset: 9c50422260f63f70116d5e10f2931764b09dd226

comment:21 Changed 8 years ago by Michael Reuter

Refs #5678. Making standalone path for system testing.

Changeset: 6c22799903dff5a6accffc2c13869032fcd0957e

comment:22 Changed 8 years ago by Michael Reuter

Refs #5678. Updating formatting.

Changeset: 561cfc7778543eecd49a2c77282dda3f1c148561

comment:23 Changed 8 years ago by Michael Reuter

Refs #5678. Adding mask saving.

Changeset: 1db1c11771b7c72279901b710d586fbcf929da2c

comment:24 Changed 8 years ago by Michael Reuter

Refs #5678. Only save mask if filename set.

Changeset: d25413c89551fd00639d26d9181da0f18a57260d

comment:25 Changed 8 years ago by Michael Reuter

Refs #5678. Fixing mask writing.

Changeset: c3842f91e64eaed89ff5ebbb8054ccfdb5c9f7c4

comment:26 Changed 8 years ago by Michael Reuter

Refs #5678 and #5855. Adding documentation.

Changeset: bc56bf07466560c835c1d4d1ccf6e6c35bfeca20

comment:27 Changed 8 years ago by Michael Reuter

Refs #5453 and #5678. Property type fixes.

Changeset: 2afc61c94ea3bc1257522ad107fcba9e219d2400

comment:28 Changed 8 years ago by Michael Reuter

Refs #5605, #5623, #5655, #5678 and #5855. Workspace prop changes.

Lots of changes relating to output workspace space properties. Handling them in a consistent manner across all algorithms.

Changeset: 3cd13c6414d1262092dc84a299c447076e0155ed

comment:29 Changed 8 years ago by Michael Reuter

Refs #5453 and #5678. Parameter fixes.

Changeset: 1dd5b6da4f26131983dbb9edab467975cf219650

comment:30 Changed 8 years ago by Michael Reuter

Refs #5678. Remove dead code.

Changeset: 6d1a76edbe1cab22162d2ac8986487a8b7b81de4

comment:31 Changed 8 years ago by Michael Reuter

Refs #5605, #5623, #5655 and #5678. Removing enable history calls.

Changeset: 462c15295188e4fb197e7547417d7a8a86ea1a5f

comment:32 Changed 8 years ago by Michael Reuter

Refs #5655 and #5678. Changes to help big memory detvan.

Changeset: 62c492f0a2faea2c9097696ba1628f81db76f440

comment:33 Changed 8 years ago by Michael Reuter

Refs #5453 and #5678. Renaming parameters.

Changeset: 01ecbd7596dae7a787457ba6edc595ea299b81b6

comment:34 Changed 8 years ago by Michael Reuter

Refs #5453 and #5678. Forgot some parameters.

Changeset: 57a6329036006b9f32141a943271442d9ec8f86a

comment:35 Changed 8 years ago by Michael Reuter

Refs #5678. Changes to get things working.

comment:36 Changed 8 years ago by Michael Reuter

Refs #5678. Fix Mac build.

Changeset: 88fa1a8c0569654f541f086d10f32f7a905fc96a

comment:37 Changed 8 years ago by Michael Reuter

Refs #5678. Another attempt at Mac/Windows fix.

Changeset: 77ca62bf052d3b3074e648c40d616e4a82d53974

comment:38 Changed 8 years ago by Michael Reuter

Refs #5678. Another attempt at Mac/Windows fix.

Changeset: ccbbc6858d82c349dd68d0f9e962650f112e9cf9

comment:39 Changed 8 years ago by Michael Reuter

Refs #5678. Temporary fix to make WinXP happy.

Changeset: 585017026382a73e902f3a6f834ddd5037090fb4

comment:40 Changed 8 years ago by Michael Reuter

Refs #5453, #5605, #5623, #5655 and #5678. More changes.

comment:41 Changed 8 years ago by Michael Reuter

Refs #5623, #5655 and #5678. Using new helper function.

Changeset: 0375945966842fffed2c14440165eb2f62b32516

comment:42 Changed 8 years ago by Michael Reuter

Refs #5678. Using boolean helper function.

Changeset: 5b47f7311f729480a5c94014cdca88479b3753bb

comment:43 Changed 8 years ago by Michael Reuter

Refs #5678. Removing magic number application.

Changeset: eb86339a77e2393cda204096a656c4ec7e186ab0

comment:44 Changed 8 years ago by Michael Reuter

Refs #5678. Match units between detvan and background workspace.

Changeset: 096efd0b814638aabdf4eb8e9b1cda91ea04ce23

comment:45 Changed 8 years ago by Michael Reuter

Refs #5453 and #5678. Fixing hard mask application.

Changeset: 194a25c22866ae020cf3a15d5d56382cd0fec3ca

comment:46 Changed 8 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

If you test #5453 or #5454 and use a detector vanadium, this comes along for the ride. Also, a system test is in place (DirectInelasticDiagnostic2.DirectInelasticDiagnostic2) that uses this algorithm and checks against the reference data for DirectInelasticDiagnostic.DirectInelasticDiagnostic

comment:47 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:48 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

Tested as part of DGSReduction

comment:49 Changed 8 years ago by Michael Reuter

Refs #5678. Making standalone path for system testing.

Changeset: 6c22799903dff5a6accffc2c13869032fcd0957e

comment:50 Changed 8 years ago by Michael Reuter

Refs #5678. Updating formatting.

Changeset: 561cfc7778543eecd49a2c77282dda3f1c148561

comment:51 Changed 8 years ago by Michael Reuter

Refs #5678. Adding mask saving.

Changeset: 1db1c11771b7c72279901b710d586fbcf929da2c

comment:52 Changed 8 years ago by Michael Reuter

Refs #5678. Only save mask if filename set.

Changeset: d25413c89551fd00639d26d9181da0f18a57260d

comment:53 Changed 8 years ago by Michael Reuter

Refs #5678. Fixing mask writing.

Changeset: c3842f91e64eaed89ff5ebbb8054ccfdb5c9f7c4

comment:54 Changed 8 years ago by Michael Reuter

Refs #5678 and #5855. Adding documentation.

Changeset: bc56bf07466560c835c1d4d1ccf6e6c35bfeca20

comment:55 Changed 8 years ago by Michael Reuter

Refs #5678. Turn off grouping for old format.

Changeset: 3e32fd9369ab990919d4f78f62acc90cbece012f

comment:56 Changed 8 years ago by Michael Reuter

Refs #5453 and #5678. Property type fixes.

Changeset: 2afc61c94ea3bc1257522ad107fcba9e219d2400

comment:57 Changed 8 years ago by Michael Reuter

Refs #5605, #5623, #5655, #5678 and #5855. Workspace prop changes.

Lots of changes relating to output workspace space properties. Handling them in a consistent manner across all algorithms.

Changeset: 3cd13c6414d1262092dc84a299c447076e0155ed

comment:58 Changed 8 years ago by Michael Reuter

Refs #5453 and #5678. Parameter fixes.

Changeset: 1dd5b6da4f26131983dbb9edab467975cf219650

comment:59 Changed 8 years ago by Michael Reuter

Refs #5678. Remove dead code.

Changeset: 6d1a76edbe1cab22162d2ac8986487a8b7b81de4

comment:60 Changed 8 years ago by Michael Reuter

Refs #5605, #5623, #5655 and #5678. Removing enable history calls.

Changeset: 462c15295188e4fb197e7547417d7a8a86ea1a5f

comment:61 Changed 8 years ago by Michael Reuter

Refs #5655 and #5678. Changes to help big memory detvan.

Changeset: 62c492f0a2faea2c9097696ba1628f81db76f440

comment:62 Changed 8 years ago by Michael Reuter

Refs #5453, #5605, #5623, #5655 and #5678. More changes.

comment:63 Changed 8 years ago by Michael Reuter

Refs #5623, #5655 and #5678. Using new helper function.

Changeset: 0375945966842fffed2c14440165eb2f62b32516

comment:64 Changed 8 years ago by Michael Reuter

Refs #5678. Using boolean helper function.

Changeset: 5b47f7311f729480a5c94014cdca88479b3753bb

comment:65 Changed 8 years ago by Michael Reuter

Refs #5678. Removing magic number application.

Changeset: eb86339a77e2393cda204096a656c4ec7e186ab0

comment:66 Changed 8 years ago by Michael Reuter

Refs #5678. Match units between detvan and background workspace.

Changeset: 096efd0b814638aabdf4eb8e9b1cda91ea04ce23

comment:67 Changed 8 years ago by Michael Reuter

Refs #5453 and #5678. Fixing hard mask application.

Changeset: 194a25c22866ae020cf3a15d5d56382cd0fec3ca

comment:68 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6524

Note: See TracTickets for help on using tickets.