Ticket #5744 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

MultiPeriodGroupAlgorithm

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

During the last iteration, MergeRuns was fixed to identify and then work correctly for multiperiod groups and groups #5646.

There are several other algorithms (and probably more to come) where the same logic applies.

Under this ticket, we will generate a new abstract algorithm called MultiPeriodGroupAlgorithm which can be used as a base class for any algorithm requiring special processing for MultiPeriod workspaces.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Owen Arnold

refs #5744. Abstract algorithm added

Changeset: 6a1906b8b34a84f3ae9d775286deaead126f8bf8

comment:3 Changed 8 years ago by Owen Arnold

refs #5744. fix naming issue

Changeset: 5dcb674e87d363af595fc78bc0bca97a7cfc29b1

comment:4 Changed 8 years ago by Owen Arnold

refs #5744. Test not required

Changeset: fb713000ccfd0e2eec372beffc6f84d173425a4b

comment:5 Changed 8 years ago by Owen Arnold

refs #5744. Make abstract class more generic

Changeset: 12b36a5dabeecf29c9afd60bccf922eac4e41715

comment:6 Changed 8 years ago by Owen Arnold

refs #5744. Extend tests to ensure other properties copied

Changeset: df63a55c328768d976e8d5267c0564cf0881313d

comment:7 Changed 8 years ago by Owen Arnold

refs #5744. Fix GCC error

Changeset: c9792dbd1a3348501d8bb45808abaf5235cc23ca

comment:8 Changed 8 years ago by Owen Arnold

refs #5744. Fix GCC error

Changeset: 70dbe8fb20f1e879d91cc9e6c6f6a8bf2f660021

comment:9 Changed 8 years ago by Owen Arnold

refs #5744. Fix warnings

Changeset: 34baf7324d2202c515e4d8ba61bd4f81a51a2916

comment:10 Changed 8 years ago by Owen Arnold

refs #5744. Fix warnings

Changeset: 2dd08bc501f991e2a1788087bada98a33715e879

comment:11 Changed 8 years ago by Owen Arnold

refs #5744. Abstract algorithm added

Changeset: 6a1906b8b34a84f3ae9d775286deaead126f8bf8

comment:12 Changed 8 years ago by Owen Arnold

refs #5744. fix naming issue

Changeset: 5dcb674e87d363af595fc78bc0bca97a7cfc29b1

comment:13 Changed 8 years ago by Owen Arnold

refs #5744. Test not required

Changeset: fb713000ccfd0e2eec372beffc6f84d173425a4b

comment:14 Changed 8 years ago by Owen Arnold

refs #5744. Make abstract class more generic

Changeset: 12b36a5dabeecf29c9afd60bccf922eac4e41715

comment:15 Changed 8 years ago by Owen Arnold

refs #5744. Extend tests to ensure other properties copied

Changeset: df63a55c328768d976e8d5267c0564cf0881313d

comment:16 Changed 8 years ago by Owen Arnold

refs #5744. Fix GCC error

Changeset: c9792dbd1a3348501d8bb45808abaf5235cc23ca

comment:17 Changed 8 years ago by Owen Arnold

refs #5744. Fix GCC error

Changeset: 70dbe8fb20f1e879d91cc9e6c6f6a8bf2f660021

comment:18 Changed 8 years ago by Owen Arnold

refs #5744. Fix warnings

Changeset: 34baf7324d2202c515e4d8ba61bd4f81a51a2916

comment:19 Changed 8 years ago by Owen Arnold

refs #5744. Fix warnings

Changeset: 2dd08bc501f991e2a1788087bada98a33715e879

comment:20 Changed 8 years ago by Owen Arnold

refs #5754 #5744 #5776. Apply MultiPeriodGroupAlgorithm.

Note that there are some minor modifications to the accessibility of some of the member functions on the Algorithm class. This is to facilitate reuse with the MultiPeriodGroupAlgorithm sub-class, which requires similar functionality.

Changeset: 91be973779562c34fee50da5890960e518d0fba5

comment:21 Changed 8 years ago by Owen Arnold

refs #5754 #5744. Fix error.

Changeset: 14b2a79f04ea01391cd952e2046dac390f3d9812

comment:22 Changed 8 years ago by Owen Arnold

refs #5754 #5744. Fix warning.

Changeset: 4a463024365c813a15cfb69fe884ffd1ca16ddf6

comment:23 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: There are stand-alone unit tests for the MultiPeriodGroupAlgorithm. However, The Multi-period group workspace functionality is also heavily tested in MergeRuns and also in StitchGroup1D. Looking at the unit tests is probably the best/only-way to test this ticket.

comment:24 Changed 8 years ago by Owen Arnold

refs #5754 #5744 #5776. Apply MultiPeriodGroupAlgorithm.

Note that there are some minor modifications to the accessibility of some of the member functions on the Algorithm class. This is to facilitate reuse with the MultiPeriodGroupAlgorithm sub-class, which requires similar functionality.

Changeset: 91be973779562c34fee50da5890960e518d0fba5

comment:25 Changed 8 years ago by Owen Arnold

refs #5754 #5744. Fix error.

Changeset: 14b2a79f04ea01391cd952e2046dac390f3d9812

comment:26 Changed 8 years ago by Owen Arnold

refs #5754 #5744. Fix warning.

Changeset: 4a463024365c813a15cfb69fe884ffd1ca16ddf6

comment:27 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:28 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to closed

comment:29 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6590

Note: See TracTickets for help on using tickets.