Ticket #5754 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Make Stitch1D a C++ Algorithm

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

"Upgrade" Stitch1D to be a c++ algorithm. This will allow us to use intermediate base classes other than Algorithm for special Multi-period group processing.

I expect (at least) no loss in performance as a result of this move. An increase is not important, but would be welcome.

Also, rename the existing python Stitch1D algorithm so that it can be kept around for comparison purposes for a while.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Owen Arnold

I'm going to call the c++ Algorithm StitchGroup1D and deprecate the existing Stitch1D algorithm. That way I won't annoy users who are already working with Stitch1D.

comment:3 Changed 8 years ago by Owen Arnold

refs #5754. Create properties.

Changeset: fe9cdfd7ac39f24c085df6b79d818d561b22bdfa

comment:4 Changed 8 years ago by Owen Arnold

refs #5754. Fully replicates existing Stitch1D pyth alg

Changeset: 8d3eab22baf98128da0e4361824802bcd72dc58c

comment:5 Changed 8 years ago by Owen Arnold

refs #5754. Add docs and fix some warnings.

Changeset: 85cfc00b86075228aae29dbd4277677a56e28d61

comment:6 Changed 8 years ago by Owen Arnold

refs #5754 reapply changes to cmakelists.txt

Changeset: 27435a1f8ff6de9b832cdd8d46411dd1816fb5cd

comment:7 Changed 8 years ago by Owen Arnold

refs #5754 Fix errors

Changeset: be2bde781c41d8ef540d3fe8b6eda049841f2369

comment:8 Changed 8 years ago by Owen Arnold

refs #5754 Fix warnings

Changeset: 922cea72be4480a4c05048345bdcf390d17e97b6

comment:9 Changed 8 years ago by Owen Arnold

refs #5754 #5744 #5776. Apply MultiPeriodGroupAlgorithm.

Note that there are some minor modifications to the accessibility of some of the member functions on the Algorithm class. This is to facilitate reuse with the MultiPeriodGroupAlgorithm sub-class, which requires similar functionality.

Changeset: 91be973779562c34fee50da5890960e518d0fba5

comment:10 Changed 8 years ago by Owen Arnold

refs #5754 #5744. Fix error.

Changeset: 14b2a79f04ea01391cd952e2046dac390f3d9812

comment:11 Changed 8 years ago by Owen Arnold

refs #5754 #5744. Fix warning.

Changeset: 4a463024365c813a15cfb69fe884ffd1ca16ddf6

comment:12 Changed 8 years ago by Owen Arnold

refs #5754. Test works correctly with mp group workspaces

Changeset: 4c4f82d82135bbc9282f6f0e0bacbd68e28f6eae

comment:13 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: You should get the same outputs out of this as you get out of the Stitch1D PythonAlgorithm. This can be easily proved, but taking the PythonAlgorithm test script (Stitch1DTest) and doing a find and replace Stitch1D -> StitchGroup1D, Workspace1 -> LHSWorkspace, Workspace2 -> LHSWorkspace etc, then running the script.

I have ~25 unit tests running against this algorithm, so I consider the test coverage quite good.

comment:14 Changed 8 years ago by Owen Arnold

refs #5754. Create properties.

Changeset: fe9cdfd7ac39f24c085df6b79d818d561b22bdfa

comment:15 Changed 8 years ago by Owen Arnold

refs #5754. Fully replicates existing Stitch1D pyth alg

Changeset: 8d3eab22baf98128da0e4361824802bcd72dc58c

comment:16 Changed 8 years ago by Owen Arnold

refs #5754. Add docs and fix some warnings.

Changeset: 85cfc00b86075228aae29dbd4277677a56e28d61

comment:17 Changed 8 years ago by Owen Arnold

refs #5754 reapply changes to cmakelists.txt

Changeset: 27435a1f8ff6de9b832cdd8d46411dd1816fb5cd

comment:18 Changed 8 years ago by Owen Arnold

refs #5754 Fix errors

Changeset: be2bde781c41d8ef540d3fe8b6eda049841f2369

comment:19 Changed 8 years ago by Owen Arnold

refs #5754 Fix warnings

Changeset: 922cea72be4480a4c05048345bdcf390d17e97b6

comment:20 Changed 8 years ago by Owen Arnold

refs #5754 #5744 #5776. Apply MultiPeriodGroupAlgorithm.

Note that there are some minor modifications to the accessibility of some of the member functions on the Algorithm class. This is to facilitate reuse with the MultiPeriodGroupAlgorithm sub-class, which requires similar functionality.

Changeset: 91be973779562c34fee50da5890960e518d0fba5

comment:21 Changed 8 years ago by Owen Arnold

refs #5754 #5744. Fix error.

Changeset: 14b2a79f04ea01391cd952e2046dac390f3d9812

comment:22 Changed 8 years ago by Owen Arnold

refs #5754 #5744. Fix warning.

Changeset: 4a463024365c813a15cfb69fe884ffd1ca16ddf6

comment:23 Changed 8 years ago by Owen Arnold

refs #5754. Test works correctly with mp group workspaces

Changeset: 4c4f82d82135bbc9282f6f0e0bacbd68e28f6eae

comment:24 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:25 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed

Stitch1D definately exists, and is a C++ algorithm. Tested manually with a single workspace case, not a group case. There is a unit test that does both.

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​6600

Note: See TracTickets for help on using tickets.