Ticket #6516 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Generating script from ORNL SANS uses import of old API

Reported by: Martyn Gigg Owned by: Mathieu Doucet
Priority: critical Milestone: Release 2.6
Component: Python Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description

I was under the impression that the SANS reduction stuff had been completely cleaned of the old API so I guess this is probably just removing some lines from the script generator?

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned
  • Keywords Maintenance added
  • Owner set to Mathieu Doucet
  • Priority changed from major to critical

comment:3 Changed 7 years ago by Mathieu Doucet

The SANS reduction code has indeed by completely migrated to API 2. At the moment, the two versions coexist. Once the instrument scientists have used the API 2 version for long enough I'll switch them to the new version of we can simply delete the old code.

comment:4 Changed 7 years ago by Mathieu Doucet

  • Status changed from assigned to accepted

comment:5 Changed 7 years ago by Mathieu Doucet

Re #6516 Make sure output is saved in the right place

Changeset: 4306f9c764c4e06b3b5655a65a019028d436efb3

comment:6 Changed 7 years ago by Mathieu Doucet

Re #6516 Make sure we can find the data files

Changeset: 318e527d5fcadddfd2d6118cf2f019af6e32867c

comment:7 Changed 7 years ago by Mathieu Doucet

Re #6516 Make sure output is saved in the right place

Changeset: 4306f9c764c4e06b3b5655a65a019028d436efb3

comment:8 Changed 7 years ago by Mathieu Doucet

Re #6516 Make sure we can find the data files

Changeset: 318e527d5fcadddfd2d6118cf2f019af6e32867c

comment:9 Changed 7 years ago by Mathieu Doucet

Re #6516 Make sure output data is saved properly

Changeset: e0335edb7d5be2328914840ef189d24167dec08a

comment:10 Changed 7 years ago by Mathieu Doucet

Re #6516 Get rid of API v1 code

Changeset: c994ea66072d7021f02626e2f4bf1b93272f10bb

comment:11 Changed 7 years ago by Mathieu Doucet

Re #6516 minor tweaks

Changeset: cc0e2b8b3760f740e5edbe841cab749da1551947

comment:12 Changed 7 years ago by Mathieu Doucet

Re #6516 Make sure output data is saved properly

Changeset: e0335edb7d5be2328914840ef189d24167dec08a

comment:13 Changed 7 years ago by Mathieu Doucet

Re #6516 Get rid of API v1 code

Changeset: c994ea66072d7021f02626e2f4bf1b93272f10bb

comment:14 Changed 7 years ago by Mathieu Doucet

Re #6516 minor tweaks

Changeset: cc0e2b8b3760f740e5edbe841cab749da1551947

comment:15 Changed 7 years ago by Mathieu Doucet

Re #6516 ghost conflict

Changeset: fdf4bf1a658e4d5a699f72ddd110a4c809fa908f

comment:16 Changed 7 years ago by Mathieu Doucet

Re #6516 Turn APIv2 on by default

Changeset: 1a132039b613b345ccc97345866bc5722c1b8cc7

comment:17 Changed 7 years ago by Mathieu Doucet

Re #6516 Turn APIv2 on by default

Changeset: 1a132039b613b345ccc97345866bc5722c1b8cc7

comment:18 Changed 7 years ago by Mathieu Doucet

Re #6516 Fix multiple background files issue

Changeset: dce581fc0363f621f3d24607a7615d3a71ce41e9

comment:19 Changed 7 years ago by Mathieu Doucet

Re #6516 Fix multiple background files issue

Changeset: dce581fc0363f621f3d24607a7615d3a71ce41e9

comment:20 Changed 7 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

This is complete for release 2.6. The old API script can still be generated at this point, but the new API is used by default. The final cleanup will be done for release 2.7 (Ticket #7053)

To test:

  • Start the ORNL SANS reduction UI and export reduction parameters to a python script.
  • The generated script should be an API v2 script.

comment:21 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:22 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

comment:23 Changed 7 years ago by Mathieu Doucet

Re #6516 Make sure output is saved in the right place

Changeset: 4306f9c764c4e06b3b5655a65a019028d436efb3

comment:24 Changed 7 years ago by Mathieu Doucet

Re #6516 Make sure we can find the data files

Changeset: 318e527d5fcadddfd2d6118cf2f019af6e32867c

comment:25 Changed 7 years ago by Mathieu Doucet

Re #6516 Make sure output data is saved properly

Changeset: e0335edb7d5be2328914840ef189d24167dec08a

comment:26 Changed 7 years ago by Mathieu Doucet

Re #6516 Get rid of API v1 code

Changeset: c994ea66072d7021f02626e2f4bf1b93272f10bb

comment:27 Changed 7 years ago by Mathieu Doucet

Re #6516 minor tweaks

Changeset: cc0e2b8b3760f740e5edbe841cab749da1551947

comment:28 Changed 7 years ago by Mathieu Doucet

Re #6516 Turn APIv2 on by default

Changeset: 1a132039b613b345ccc97345866bc5722c1b8cc7

comment:29 Changed 7 years ago by Mathieu Doucet

Re #6516 Fix multiple background files issue

Changeset: dce581fc0363f621f3d24607a7615d3a71ce41e9

comment:30 Changed 7 years ago by Mathieu Doucet

Re #6516 Make sure output is saved in the right place

Changeset: 4306f9c764c4e06b3b5655a65a019028d436efb3

comment:31 Changed 7 years ago by Mathieu Doucet

Re #6516 Make sure we can find the data files

Changeset: 318e527d5fcadddfd2d6118cf2f019af6e32867c

comment:32 Changed 7 years ago by Mathieu Doucet

Re #6516 Make sure output data is saved properly

Changeset: e0335edb7d5be2328914840ef189d24167dec08a

comment:33 Changed 7 years ago by Mathieu Doucet

Re #6516 Get rid of API v1 code

Changeset: c994ea66072d7021f02626e2f4bf1b93272f10bb

comment:34 Changed 7 years ago by Mathieu Doucet

Re #6516 minor tweaks

Changeset: cc0e2b8b3760f740e5edbe841cab749da1551947

comment:35 Changed 7 years ago by Mathieu Doucet

Re #6516 Turn APIv2 on by default

Changeset: 1a132039b613b345ccc97345866bc5722c1b8cc7

comment:36 Changed 7 years ago by Mathieu Doucet

Re #6516 Fix multiple background files issue

Changeset: dce581fc0363f621f3d24607a7615d3a71ce41e9

comment:37 Changed 7 years ago by Owen Arnold

Merge branch 'feature/7022_alg_dialogs' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:38 Changed 7 years ago by Owen Arnold

Merge branch 'feature/7022_alg_dialogs' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:39 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:40 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Python API

comment:41 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7362

Note: See TracTickets for help on using tickets.