Ticket #6583 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Ongoing Warning Fixes

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

Warning fixes for iteration 2.5 As an effort to keep the number of warnings = 0

Check and fix warnings on a regular (ideally daily) basis.

Change History

comment:1 Changed 8 years ago by Owen Arnold

refs #6583. Warning fixes

Changeset: f3d8eaa3b87a4f8f508cfd95b7f2af3877709594

comment:2 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:3 Changed 8 years ago by Owen Arnold

refs #6583. Fit warning.

Changeset: e317b10771a6634c57a46221d66fae9ed07d00ff

comment:4 Changed 8 years ago by Owen Arnold

refs #6583. Fedora warnings.

Changeset: b18410ff38076cfb53e2abf87c0c5362feb023be

comment:5 Changed 8 years ago by Owen Arnold

refs #6583. const cast Fedora warnings.

Changeset: 7586ff065be0509b78a7373f837ec27b8e7d2fcf

comment:6 Changed 8 years ago by Owen Arnold

refs #6583. Uninitialized array ptr warning.

Changeset: 38298ede2ffed7513f03b49b9340372b0a0586e7

comment:7 Changed 8 years ago by Owen Arnold

refs #6583. Fix uninitialized var error.

Changeset: d072b4d0a169e448a8fc6ba32bd0a19af57dce4e

comment:8 Changed 8 years ago by Owen Arnold

refs #6583. Fix non virtual destructors.

Changeset: a6a227e0809267f69ac167d76978112565cd4ff9

comment:9 Changed 8 years ago by Owen Arnold

refs #6583. More fedora fixes.

Changeset: 677ed8d87bc04f509c4570dfe4a43ef78398be5e

comment:10 Changed 8 years ago by Owen Arnold

refs #6583. Non-virtual destructor fix.

Changeset: 5f56b23ee20c3fdbe9c2a21e55ebd2a51c59ecc8

comment:11 Changed 8 years ago by Owen Arnold

refs #6583. const cast fixes.

Changeset: 15893df1984925a46641dd64908ced09164683a1

comment:12 Changed 8 years ago by Owen Arnold

refs #6583. remove typedef.

Changeset: b9dedfd666a9a5e7b551ac3dfa75c56b52b217dd

comment:13 Changed 8 years ago by Owen Arnold

refs #6583. Fix type cast.

Changeset: e6dfd055347a16205454172c6512da2e93094617

comment:14 Changed 8 years ago by Owen Arnold

Revert "refs #6583. Fix type cast."

This reverts commit e6dfd055347a16205454172c6512da2e93094617.

Changeset: e1b3e60238b25871abeecccc71be586ddc5801f8

comment:15 Changed 8 years ago by Owen Arnold

refs #6583. Unused param fix.

Changeset: 32d2f37646f167dc443c9afafeab5786865795e7

comment:16 Changed 8 years ago by Owen Arnold

refs #6583. More fedora fixes.

Changeset: 0f158f54e46c08bbcc97204a536ce736a18484b7

comment:17 Changed 8 years ago by Owen Arnold

refs #6583. fix const cast.

Changeset: abfaccfd05f9cf3170b6f2e5ab2de47c305ebb22

comment:18 Changed 8 years ago by Owen Arnold

refs #6583. Fix doxygen

Changeset: f2b937fb6f7ab2503fc6a40b7618af8d80182f85

comment:19 Changed 8 years ago by Owen Arnold

refs #6583. Algorithm tests warning fixes.

Changeset: 8e81a186c27fdedc6777adcff63f1456b52e2101

comment:20 Changed 8 years ago by Owen Arnold

refs #6583. Fix vc++ warnings.

Changeset: 6ebf352f415595de0fbb239ccd35e8d944bfe48b

comment:21 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

I'm closing this ticket, because it doesn't fit any longer under our new git workflow. When I created this ticket, it was possible (and necessary) for me to correct warnings occuring on Mantid following nightly builds. However my new approach is:

  • Monitor warnings on develop
  • Email the owner to fix the warning they introduced

There's no good test for this ticket, since all of the commits should already be in master. Things should still build and pass testing with these changes. The changes should have solved the warnings they were meant to target.

comment:22 Changed 8 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:23 Changed 8 years ago by Russell Taylor

  • Status changed from verifying to closed

comment:24 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7429

Note: See TracTickets for help on using tickets.