Ticket #6655 (closed: fixed)
SaveGSS fails when there is a dot in the path other than before the extension
Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
---|---|---|---|
Priority: | major | Milestone: | Release 2.5 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Russell Taylor |
Description
The PEARL system test is failing on the is_test_ubuntu_12.04_develop branch because SaveGSS thinks everything after the first period is an extension then tries to open a file that doesn't exist,
SaveGSS-[Notice] SaveGSS started SaveGSS-[Information] Algorithm: SaveGSS v1 SaveGSS-[Information] Parameters: SaveGSS-[Information] Name: InputWorkspace, Value: bank1, Default?: No, Direction: Input SaveGSS-[Information] Name: Filename, Value: /home/mantidlog/jenkins/workspace/is_test_ubuntu-12.04_develop/logs/PRL74795_74797.gss, Default?: No, Direction: Input SaveGSS-[Information] Name: SplitFiles, Value: True, Default?: Yes, Direction: Input SaveGSS-[Information] Name: Append, Value: 0, Default?: No, Direction: Input SaveGSS-[Information] Name: Bank, Value: 1, Default?: Yes, Direction: Input SaveGSS-[Information] Name: Format, Value: RALF, Default?: Yes, Direction: Input SaveGSS-[Information] Name: MultiplyByBinWidth, Value: 1, Default?: Yes, Direction: Input SaveGSS-[Information] Name: ExtendedHeader, Value: 0, Default?: Yes, Direction: Input SaveGSS-[Information] L1 = 12.8 L2 = 0.786952 2theta = 1.5708 SaveGSS-[Information] Could not open filename: /home/mantidlog/jenkins/workspace/is_test_ubuntu-12 SaveGSS-[Error] Error in execution of algorithm SaveGSS: SaveGSS-[Error] Could not open filename: /home/mantidlog/jenkins/workspace/is_test_ubuntu-12 Traceback (most recent call last): File "<string>", line 1, in <module> File "/home/mantidlog/jenkins/workspace/is_test_ubuntu-12.04_develop/StressTestFramework/stresstesting.py", line 173, in execute self.runTest() File "/home/mantidlog/jenkins/workspace/is_test_ubuntu-12.04_develop/SystemTests/AnalysisTests/PEARLSystemTest.py", line 30, in runTest self.do_focus() File "/home/mantidlog/jenkins/workspace/is_test_ubuntu-12.04_develop/SystemTests/AnalysisTests/PEARLSystemTest.py", line 383, in do_focus return self.PEARL_focus("74795_74797","raw",fmode="all",ttmode="TT70",atten=False) File "/home/mantidlog/jenkins/workspace/is_test_ubuntu-12.04_develop/SystemTests/AnalysisTests/PEARLSystemTest.py", line 218, in PEARL_focus saveGSS = SaveGSS("bank1",Filename=gssfile,Append=False,Bank=1) File "/opt/Mantid/bin/mantidsimple.py", line 42, in algorithm_wrapper algm.execute() RuntimeError: Could not open filename: /home/mantidlog/jenkins/workspace/is_test_ubuntu-12
Change History
comment:2 Changed 8 years ago by Martyn Gigg
Fix SaveGSS when other period characters in filename. Refs #6655
It used to assume the first period marked the extension but this is not the case for example in is_test_ubuntu-12.04* jobs on the buildserver
Changeset: 9e0ba6bf627f7eb345cd8ce9a510dbcc9035b074
comment:3 Changed 8 years ago by Martyn Gigg
Fix SaveGSS when other period characters in filename. Refs #6655
It used to assume the first period marked the extension but this is not the case for example in is_test_ubuntu-12.04* jobs on the buildserver
Changeset: 9e0ba6bf627f7eb345cd8ce9a510dbcc9035b074
comment:4 Changed 8 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
Tester: The script below will produce a workspace suitable for saving to a GSAS file. To test:
- First make a directory that contains a period in it i.e. savedir/12.04
- Run the script at the bottom of this comment
- Run SaveGSS and create a filename that includes the directory that you just created
- Check the SplitFiles option does the expected thing. If true then 3 files should be created each with the original filename as a stem, if false then a single file should be created with the original filename
LoadRaw(Filename="HRP39191.RAW",OutputWorkspace="Vanadium") #align vanadium detectors AlignDetectors(InputWorkspace="Vanadium",OutputWorkspace="Vanadium",CalibrationFile="hrpd_new_072_01_corr.cal") ConvertUnits(InputWorkspace="Vanadium",OutputWorkspace="Vanadium",Target="dSpacing") DiffractionFocussing(InputWorkspace="Vanadium",OutputWorkspace="Vanadium",GroupingFileName="hrpd_new_072_01_corr.cal") ConvertUnits(InputWorkspace="Vanadium",OutputWorkspace="Vanadium",Target="TOF")
comment:5 Changed 8 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:6 Changed 8 years ago by Martyn Gigg
Fix SaveGSS when other period characters in filename. Refs #6655
It used to assume the first period marked the extension but this is not the case for example in is_test_ubuntu-12.04* jobs on the buildserver
Changeset: 9e0ba6bf627f7eb345cd8ce9a510dbcc9035b074
comment:7 Changed 8 years ago by Russell Taylor
- Status changed from verifying to closed
Worked once I figured out that the files in the script above aren't in the AutoTest directory :)
comment:8 Changed 8 years ago by Martyn Gigg
Fix SaveGSS when other period characters in filename. Refs #6655
It used to assume the first period marked the extension but this is not the case for example in is_test_ubuntu-12.04* jobs on the buildserver
Changeset: 624ed1067402761b16b88704173781caee7d9b1c
The branch name is: bug/6655_savegss_fail