Ticket #6694 (closed: fixed)
Refactor GenerateEventsFilter()
| Reported by: | Wenduo Zhou | Owned by: | Wenduo Zhou |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.5 |
| Component: | Mantid | Keywords: | |
| Cc: | saviciat@… | Blocked By: | |
| Blocking: | Tester: | Andrei Savici |
Description
The default values of StartTime and StopTime should be set to Empty Double.
The codes to process single value filter and multiple value filter can be merged.
Change History
comment:2 Changed 8 years ago by Wenduo Zhou
Change the default values of StartTime/StopTime. Refs #6694.
Changeset: a52eab73c99d9be7caed2c20338d36acc81a7b81
comment:3 Changed 8 years ago by Wenduo Zhou
Change the default values of StartTime/StopTime. Refs #6694.
Changeset: a52eab73c99d9be7caed2c20338d36acc81a7b81
comment:4 Changed 8 years ago by Wenduo Zhou
Fix some error. Refs #6694.
Changeset: ca284c0c81a0e40f22947d1737926f7e558191e4
comment:5 Changed 8 years ago by Wenduo Zhou
Fix some error. Refs #6694.
Changeset: ca284c0c81a0e40f22947d1737926f7e558191e4
comment:6 Changed 8 years ago by Wenduo Zhou
Merge filter single value and multiple value functions. Refs #6694.
Changeset: cf7f3fc2b9143af8b4216d944d996842ec4bfb08
comment:7 Changed 8 years ago by Wenduo Zhou
Remove used methods. Refs #6694.
Changeset: 2cdbc4b35e5ff619b8963d555ac4ff6a01c2b9c3
comment:8 Changed 8 years ago by Wenduo Zhou
Add visibility property to some properties. Refs #6694.
Changeset: 77354aa382e3d0a89ce1ac986cdf81e094cae478
comment:9 Changed 8 years ago by Wenduo Zhou
Merge filter single value and multiple value functions. Refs #6694.
Changeset: cf7f3fc2b9143af8b4216d944d996842ec4bfb08
comment:10 Changed 8 years ago by Wenduo Zhou
Remove used methods. Refs #6694.
Changeset: 2cdbc4b35e5ff619b8963d555ac4ff6a01c2b9c3
comment:11 Changed 8 years ago by Wenduo Zhou
Add visibility property to some properties. Refs #6694.
Changeset: 77354aa382e3d0a89ce1ac986cdf81e094cae478
comment:12 Changed 8 years ago by Wenduo Zhou
Fix the system test due to mod of property. Refs #6694.
Changeset: 196fabeea9ff9e40a5e1a68aceeed60dd708aa29
comment:13 Changed 8 years ago by Wenduo Zhou
Fix the system test due to mod of property. Refs #6694.
Changeset: 196fabeea9ff9e40a5e1a68aceeed60dd708aa29
comment:14 Changed 8 years ago by Wenduo Zhou
Modify the reference file. Refs #6694.
The boundary of the splitters are changed due to a bug fixed in GenerateEventsFilter(). Thus the reference file is replaced by a corrected one.
Changeset: 4c6c39f11292671adc7982ce645b751d2389e580
comment:15 Changed 8 years ago by Wenduo Zhou
Modify the reference file. Refs #6694.
The boundary of the splitters are changed due to a bug fixed in GenerateEventsFilter(). Thus the reference file is replaced by a corrected one.
Changeset: 4c6c39f11292671adc7982ce645b751d2389e580
comment:16 Changed 8 years ago by Wenduo Zhou
Fixed a bug in creating splitter. Refs #6694.
Changeset: c983befb1401a0bfd907da30252cc3ffe8939755
comment:17 Changed 8 years ago by Wenduo Zhou
Fixed a bug in creating splitter. Refs #6694.
Changeset: c983befb1401a0bfd907da30252cc3ffe8939755
comment:18 Changed 8 years ago by Wenduo Zhou
Fix a warning of type conversion. Refs #6694.
Changeset: add41aa3c7a3b92ec9756233800557646f466cd2
comment:19 Changed 8 years ago by Wenduo Zhou
Fix a warning of type conversion. Refs #6694.
Changeset: add41aa3c7a3b92ec9756233800557646f466cd2
comment:20 Changed 8 years ago by Wenduo Zhou
- Status changed from accepted to verify
- Resolution set to fixed
How to test: As the purpose of this ticket is to modify the input properties and refactor some redundant codes, there is no new feature to show. By passing the unit test and system test (HYSPEC), the ticket can be seen as 'fixed'.
comment:21 Changed 8 years ago by Wenduo Zhou
Change the default values of StartTime/StopTime. Refs #6694.
Changeset: c50d8a7f51bac67ffd9f32b0bd38e32dc72693ff
comment:22 Changed 8 years ago by Wenduo Zhou
Change the default values of StartTime/StopTime. Refs #6694.
Changeset: c50d8a7f51bac67ffd9f32b0bd38e32dc72693ff
comment:23 Changed 8 years ago by Wenduo Zhou
Fix some error. Refs #6694.
Changeset: e4af961a80dc89db5cc7b40d1aecd2383fa922cf
comment:24 Changed 8 years ago by Wenduo Zhou
Merge filter single value and multiple value functions. Refs #6694.
Changeset: f57cc4652ddb6604b5f2fc21993e17ef1b42cfc8
comment:25 Changed 8 years ago by Wenduo Zhou
Remove used methods. Refs #6694.
Changeset: 12ae93a8bc2d87b0c1280a2f6030f7ead0b3de66
comment:26 Changed 8 years ago by Wenduo Zhou
Add visibility property to some properties. Refs #6694.
Changeset: e46badfc4bbda9f886f249820681851b1e445af9
comment:27 Changed 8 years ago by Wenduo Zhou
Fixed a bug in creating splitter. Refs #6694.
Changeset: 10fffea78da25c21c0e70cb8fb9f18e794a0e0f0
comment:28 Changed 8 years ago by Wenduo Zhou
Fix a warning of type conversion. Refs #6694.
Changeset: d6f6e925f58b1356e08b365a24149ed7a0560b3b
comment:29 Changed 8 years ago by Wenduo Zhou
Fixed a warning. Refs #6694.
Changeset: ee61737e37d1fb9108591a438ca9acbfa4b3577d
comment:30 Changed 8 years ago by Wenduo Zhou
Fix some error. Refs #6694.
Changeset: e4af961a80dc89db5cc7b40d1aecd2383fa922cf
comment:31 Changed 8 years ago by Wenduo Zhou
Merge filter single value and multiple value functions. Refs #6694.
Changeset: f57cc4652ddb6604b5f2fc21993e17ef1b42cfc8
comment:32 Changed 8 years ago by Wenduo Zhou
Remove used methods. Refs #6694.
Changeset: 12ae93a8bc2d87b0c1280a2f6030f7ead0b3de66
comment:33 Changed 8 years ago by Wenduo Zhou
Add visibility property to some properties. Refs #6694.
Changeset: e46badfc4bbda9f886f249820681851b1e445af9
comment:34 Changed 8 years ago by Wenduo Zhou
Fixed a bug in creating splitter. Refs #6694.
Changeset: 10fffea78da25c21c0e70cb8fb9f18e794a0e0f0
comment:35 Changed 8 years ago by Wenduo Zhou
Fix a warning of type conversion. Refs #6694.
Changeset: d6f6e925f58b1356e08b365a24149ed7a0560b3b
comment:36 Changed 8 years ago by Wenduo Zhou
Fixed a warning. Refs #6694.
Changeset: ee61737e37d1fb9108591a438ca9acbfa4b3577d
comment:37 Changed 8 years ago by Russell Taylor
The branch for this is feature/6694_genfilter NOT wzhou/6694_genfilter (which was created off of develop by mistake and needs to be deleted).
comment:38 Changed 8 years ago by Wenduo Zhou
Fix the system test due to mod of property. Refs #6694.
Changeset: 3e579afd199cea265b00530171fb2c25b036e396
comment:39 Changed 8 years ago by Wenduo Zhou
Modify the reference file. Refs #6694.
The boundary of the splitters are changed due to a bug fixed in GenerateEventsFilter(). Thus the reference file is replaced by a corrected one.
Changeset: e9505b0fadf0737dfa092bd1052e02a327ae2fc5
comment:40 Changed 8 years ago by Wenduo Zhou
Fix the system test due to mod of property. Refs #6694.
Changeset: 3e579afd199cea265b00530171fb2c25b036e396
comment:41 Changed 8 years ago by Wenduo Zhou
Modify the reference file. Refs #6694.
The boundary of the splitters are changed due to a bug fixed in GenerateEventsFilter(). Thus the reference file is replaced by a corrected one.
Changeset: e9505b0fadf0737dfa092bd1052e02a327ae2fc5
comment:42 Changed 8 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:43 Changed 8 years ago by Andrei Savici
- Status changed from verifying to reopened
- Resolution fixed deleted
The filtering works, but it has errors. Load HYS_13656 from systemtests data as workspace sum1, then just run lines 26 and 27 in the HYSPEC system test. The generated events filter info file goes with s1 values to ~24.7 instead of 24.5 for workspace 8. Then the filetered workspace 8 contains logs of s1 up to ~90
comment:44 Changed 8 years ago by Wenduo Zhou
Removed debug output. Refs #6694.
Changeset: 5250cfba70c02ba1450ed56e699c2645ec3f03f3
comment:45 Changed 8 years ago by Wenduo Zhou
Removed debug output. Refs #6694.
Changeset: 5250cfba70c02ba1450ed56e699c2645ec3f03f3
comment:47 Changed 8 years ago by Wenduo Zhou
- Status changed from accepted to verify
- Resolution set to fixed
comment:49 Changed 8 years ago by Andrei Savici
The unfiltered event workspace contain all logs instead of just those above my maximum value. See #6720
comment:51 Changed 8 years ago by Wenduo Zhou
Change the default values of StartTime/StopTime. Refs #6694.
Changeset: a646e62fab30257303427e68bb75cdf744d72e22
comment:52 Changed 8 years ago by Wenduo Zhou
Fix some error. Refs #6694.
Changeset: 2c79c11e39dac59d11f74170e0614c5a84755a35
comment:53 Changed 8 years ago by Wenduo Zhou
Merge filter single value and multiple value functions. Refs #6694.
Changeset: 3a99092ed66f98cd01bc56d4b4cd7a4011be180c
comment:54 Changed 8 years ago by Wenduo Zhou
Remove used methods. Refs #6694.
Changeset: 42e3081fd0c5aa178ed6dc5162e74f6e78d2cd0e
comment:55 Changed 8 years ago by Wenduo Zhou
Add visibility property to some properties. Refs #6694.
Changeset: 550e22a30d4c45615617a1fa8a329c3ff1659d9d
comment:56 Changed 8 years ago by Wenduo Zhou
Fixed a bug in creating splitter. Refs #6694.
Changeset: 69903549f5a8bde223242dba770333b29fa98a69
comment:57 Changed 8 years ago by Wenduo Zhou
Fix a warning of type conversion. Refs #6694.
Changeset: f97753697141138c88c7bedf9109d636f171c178
comment:58 Changed 8 years ago by Wenduo Zhou
Fixed a warning. Refs #6694.
Changeset: e89cded90e3c243b884d336ae58d2e6c53d62460
comment:59 Changed 7 years ago by Wenduo Zhou
Change the default values of StartTime/StopTime. Refs #6694.
Changeset: a52eab73c99d9be7caed2c20338d36acc81a7b81
comment:60 Changed 7 years ago by Wenduo Zhou
Fix some error. Refs #6694.
Changeset: ca284c0c81a0e40f22947d1737926f7e558191e4
comment:61 Changed 7 years ago by Wenduo Zhou
Merge filter single value and multiple value functions. Refs #6694.
Changeset: cf7f3fc2b9143af8b4216d944d996842ec4bfb08
comment:62 Changed 7 years ago by Wenduo Zhou
Remove used methods. Refs #6694.
Changeset: 2cdbc4b35e5ff619b8963d555ac4ff6a01c2b9c3
comment:63 Changed 7 years ago by Wenduo Zhou
Add visibility property to some properties. Refs #6694.
Changeset: 77354aa382e3d0a89ce1ac986cdf81e094cae478
comment:64 Changed 7 years ago by Wenduo Zhou
Fixed a bug in creating splitter. Refs #6694.
Changeset: c983befb1401a0bfd907da30252cc3ffe8939755
comment:65 Changed 7 years ago by Wenduo Zhou
Fix a warning of type conversion. Refs #6694.
Changeset: add41aa3c7a3b92ec9756233800557646f466cd2
comment:66 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7540
