Ticket #6752 (closed: fixed)
Improve comments in Tube Calibration Example Scripts
Reported by: | Karl Palmen | Owned by: | Karl Palmen |
---|---|---|---|
Priority: | major | Milestone: | Release 2.5 |
Component: | Mantid | Keywords: | |
Cc: | anders.markvardsen@… | Blocked By: | |
Blocking: | Tester: | Anders Markvardsen |
Description
This ticket is for improving the comments in the python example scripts to make them easier to be used by scientists. Also it is for udating the wiki pages for Tube Calibration.
Ticket to be tested by Anders Marksvardsen
Change History
comment:1 Changed 8 years ago by Karl Palmen
- Status changed from new to assigned
- Owner set to Karl Palmen
comment:3 Changed 8 years ago by Karl Palmen
Improvements to TubeCalibDemoMaps_B1.py re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 6bc875ebfe1884dd33de837991222fbc2017c366
comment:4 Changed 8 years ago by Karl Palmen
Final improvement to TubCalibDemoMaps_B1.py re #6752
Now I can make similar changes to other scripts.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 2da18ac5d460eb01138515c742760f1471adf7cd
comment:5 Changed 8 years ago by Karl Palmen
Add changes to other examples re #6752
Work cannot be completed until ticket #6764 has been closed. Then the comments in the code from that ticket can be improved similarly.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 469b50b4a5221e8663322963c6ed73bcc50c2c69
comment:6 Changed 8 years ago by Karl Palmen
Applied changes to new examples from #6764 re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 3e83adf44585ff5756a203dac1252bb36d84fa87
comment:7 Changed 8 years ago by Karl Palmen
Made change to example from #6742 re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 86c543a0dfff6e3770062edaaea38a721c4e55ba
comment:8 Changed 8 years ago by Karl Palmen
Improvements to TubeCalibDemoMaps_B1.py re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 6bc875ebfe1884dd33de837991222fbc2017c366
comment:9 Changed 8 years ago by Karl Palmen
Final improvement to TubCalibDemoMaps_B1.py re #6752
Now I can make similar changes to other scripts.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 2da18ac5d460eb01138515c742760f1471adf7cd
comment:10 Changed 8 years ago by Karl Palmen
Add changes to other examples re #6752
Work cannot be completed until ticket #6764 has been closed. Then the comments in the code from that ticket can be improved similarly.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 469b50b4a5221e8663322963c6ed73bcc50c2c69
comment:11 Changed 8 years ago by Karl Palmen
Applied changes to new examples from #6764 re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 3e83adf44585ff5756a203dac1252bb36d84fa87
comment:12 Changed 8 years ago by Karl Palmen
Made change to example from #6742 re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 86c543a0dfff6e3770062edaaea38a721c4e55ba
comment:13 Changed 8 years ago by Karl Palmen
Merge remote-tracking branch 'origin/master' into feature/6752_improve_comments
Refs #6752
Conflicts:
Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_All.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_B1.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_D2.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_D4.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_Simple.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoWish0.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoWish_Simple.py
Changeset: 7de1dd440197c220eff43a9331bac89edf4d8ef4
comment:14 Changed 8 years ago by Karl Palmen
comment:15 Changed 8 years ago by Karl Palmen
- Status changed from accepted to verify
- Resolution set to fixed
comment:16 Changed 7 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester set to Anders Markvardsen
comment:17 Changed 7 years ago by Anders Markvardsen
- Status changed from verifying to closed
The comments have been changed as discussed
comment:18 Changed 7 years ago by Karl Palmen
Improvements to TubeCalibDemoMaps_B1.py re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 6bc875ebfe1884dd33de837991222fbc2017c366
comment:19 Changed 7 years ago by Karl Palmen
Final improvement to TubCalibDemoMaps_B1.py re #6752
Now I can make similar changes to other scripts.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 2da18ac5d460eb01138515c742760f1471adf7cd
comment:20 Changed 7 years ago by Karl Palmen
Add changes to other examples re #6752
Work cannot be completed until ticket #6764 has been closed. Then the comments in the code from that ticket can be improved similarly.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 469b50b4a5221e8663322963c6ed73bcc50c2c69
comment:21 Changed 7 years ago by Karl Palmen
Applied changes to new examples from #6764 re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 3e83adf44585ff5756a203dac1252bb36d84fa87
comment:22 Changed 7 years ago by Karl Palmen
Made change to example from #6742 re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 86c543a0dfff6e3770062edaaea38a721c4e55ba
comment:23 Changed 7 years ago by Karl Palmen
Improvements to TubeCalibDemoMaps_B1.py re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 6bc875ebfe1884dd33de837991222fbc2017c366
comment:24 Changed 7 years ago by Karl Palmen
Final improvement to TubCalibDemoMaps_B1.py re #6752
Now I can make similar changes to other scripts.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 2da18ac5d460eb01138515c742760f1471adf7cd
comment:25 Changed 7 years ago by Karl Palmen
Add changes to other examples re #6752
Work cannot be completed until ticket #6764 has been closed. Then the comments in the code from that ticket can be improved similarly.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 469b50b4a5221e8663322963c6ed73bcc50c2c69
comment:26 Changed 7 years ago by Karl Palmen
Applied changes to new examples from #6764 re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 3e83adf44585ff5756a203dac1252bb36d84fa87
comment:27 Changed 7 years ago by Karl Palmen
Made change to example from #6742 re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 86c543a0dfff6e3770062edaaea38a721c4e55ba
comment:28 Changed 7 years ago by Karl Palmen
Improvements to TubeCalibDemoMaps_B1.py re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 6bc875ebfe1884dd33de837991222fbc2017c366
comment:29 Changed 7 years ago by Karl Palmen
Final improvement to TubCalibDemoMaps_B1.py re #6752
Now I can make similar changes to other scripts.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 2da18ac5d460eb01138515c742760f1471adf7cd
comment:30 Changed 7 years ago by Karl Palmen
Add changes to other examples re #6752
Work cannot be completed until ticket #6764 has been closed. Then the comments in the code from that ticket can be improved similarly.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 469b50b4a5221e8663322963c6ed73bcc50c2c69
comment:31 Changed 7 years ago by Karl Palmen
Applied changes to new examples from #6764 re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 3e83adf44585ff5756a203dac1252bb36d84fa87
comment:32 Changed 7 years ago by Karl Palmen
Made change to example from #6742 re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 86c543a0dfff6e3770062edaaea38a721c4e55ba
comment:33 Changed 7 years ago by Karl Palmen
Improvements to TubeCalibDemoMaps_B1.py re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 6bc875ebfe1884dd33de837991222fbc2017c366
comment:34 Changed 7 years ago by Karl Palmen
Final improvement to TubCalibDemoMaps_B1.py re #6752
Now I can make similar changes to other scripts.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 2da18ac5d460eb01138515c742760f1471adf7cd
comment:35 Changed 7 years ago by Karl Palmen
Add changes to other examples re #6752
Work cannot be completed until ticket #6764 has been closed. Then the comments in the code from that ticket can be improved similarly.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 469b50b4a5221e8663322963c6ed73bcc50c2c69
comment:36 Changed 7 years ago by Karl Palmen
Applied changes to new examples from #6764 re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 3e83adf44585ff5756a203dac1252bb36d84fa87
comment:37 Changed 7 years ago by Karl Palmen
Made change to example from #6742 re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 86c543a0dfff6e3770062edaaea38a721c4e55ba
comment:38 Changed 7 years ago by Karl Palmen
Merge remote-tracking branch 'origin/master' into feature/6752_improve_comments
Refs #6752
Conflicts:
Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_All.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_B1.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_D2.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_D4.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_Simple.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoWish0.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoWish_Simple.py
Changeset: 7de1dd440197c220eff43a9331bac89edf4d8ef4
comment:39 Changed 7 years ago by Karl Palmen
Merge remote-tracking branch 'origin/master' into feature/6752_improve_comments
Refs #6752
Conflicts:
Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_All.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_B1.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_D2.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_D4.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_Simple.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoWish0.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoWish_Simple.py
Changeset: 7de1dd440197c220eff43a9331bac89edf4d8ef4
comment:40 Changed 7 years ago by Karl Palmen
Merge remote-tracking branch 'origin/master' into feature/6752_improve_comments
Refs #6752
Conflicts:
Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_All.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_B1.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_D2.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_D4.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_Simple.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoWish0.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoWish_Simple.py
Changeset: 7de1dd440197c220eff43a9331bac89edf4d8ef4
comment:41 Changed 7 years ago by Karl Palmen
Improvements to TubeCalibDemoMaps_B1.py re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 6bc875ebfe1884dd33de837991222fbc2017c366
comment:42 Changed 7 years ago by Karl Palmen
Final improvement to TubCalibDemoMaps_B1.py re #6752
Now I can make similar changes to other scripts.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 2da18ac5d460eb01138515c742760f1471adf7cd
comment:43 Changed 7 years ago by Karl Palmen
Add changes to other examples re #6752
Work cannot be completed until ticket #6764 has been closed. Then the comments in the code from that ticket can be improved similarly.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 469b50b4a5221e8663322963c6ed73bcc50c2c69
comment:44 Changed 7 years ago by Karl Palmen
Applied changes to new examples from #6764 re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 3e83adf44585ff5756a203dac1252bb36d84fa87
comment:45 Changed 7 years ago by Karl Palmen
Made change to example from #6742 re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 86c543a0dfff6e3770062edaaea38a721c4e55ba
comment:46 Changed 7 years ago by Karl Palmen
Merge remote-tracking branch 'origin/master' into feature/6752_improve_comments
Refs #6752
Conflicts:
Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_All.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_B1.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_D2.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_D4.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_Simple.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoWish0.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoWish_Simple.py
Changeset: 7de1dd440197c220eff43a9331bac89edf4d8ef4
comment:47 Changed 7 years ago by Karl Palmen
Merge remote-tracking branch 'origin/master' into feature/6752_improve_comments
Refs #6752
Conflicts:
Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_All.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_B1.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_D2.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_D4.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_Simple.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoWish0.py Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoWish_Simple.py
Changeset: 7de1dd440197c220eff43a9331bac89edf4d8ef4
comment:48 Changed 7 years ago by Karl Palmen
Applied changes to new examples from #6764 re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 3e83adf44585ff5756a203dac1252bb36d84fa87
comment:49 Changed 7 years ago by Karl Palmen
Made change to example from #6742 re #6752
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 86c543a0dfff6e3770062edaaea38a721c4e55ba
comment:50 Changed 7 years ago by Karl Palmen
Merge branch 'feature/6752_improve_comments' into develop into 6856_ConvertToDiffractionMDWS_v2
comment:51 Changed 7 years ago by Karl Palmen
Merge branch 'feature/6752_improve_comments' into develop into 6856_ConvertToDiffractionMDWS_v2
comment:52 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7598