Ticket #6793 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Add setting explicit angles to SetGoniometer

Reported by: Peter Peterson Owned by: Andrei Savici
Priority: critical Milestone: Release 2.5
Component: Mantid Keywords:
Cc: pascal.manuel@… Blocked By:
Blocking: Tester: Peter Peterson

Description

In SetGoniometer the user currently needs to specify motors for the rotation angles. Add support for the angles to be explicitly specified. This is currently needed on WISH, but it will likely be needed by other instruments as well.

Change History

comment:1 Changed 8 years ago by Andrei Savici

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Andrei Savici

Goniometer can take a number instead of log value. Refs #6793

Changeset: 2655fc449a7ecff2792dac9604c7e2f9cbc61152

comment:3 Changed 8 years ago by Andrei Savici

Goniometer can take a number instead of log value. Refs #6793

Changeset: 2655fc449a7ecff2792dac9604c7e2f9cbc61152

comment:4 Changed 8 years ago by Andrei Savici

Change wiki section. Refs #6793

Changeset: 5dc9cf37bc898ebbb4beedd2d05ea55803e875b7

comment:5 Changed 8 years ago by Andrei Savici

Change wiki section. Refs #6793

Changeset: 5dc9cf37bc898ebbb4beedd2d05ea55803e875b7

comment:6 Changed 8 years ago by Andrei Savici

  • Status changed from accepted to verify
  • Resolution set to fixed

Branch feature/6793_setGoniometer_improvement. To test: Load a workspace, use SetGoniometer. One of the axis should have a number instead of a log name. The output workspace should contain a new log value - i.e. GoniometerAxis0_FixedValue. From python you can also get the Euler angles (ws.run().getGoniometer().getEulerAngles("XYZ") or whatever convention you like)

comment:7 Changed 8 years ago by Peter Peterson

  • Status changed from verify to reopened
  • Resolution fixed deleted

The system tests don't pass on mac build.

comment:8 Changed 8 years ago by Peter Peterson

The last comment was meant for #6650. Please re-close the ticket.

comment:9 Changed 8 years ago by Peter Peterson

Actually there is a problem to fix before it is closed again: The log value that is created does not have units. Also, the new feature is not documented in the wiki page or in the mouse-over help.

comment:10 Changed 8 years ago by Andrei Savici

SetGoniometer small changes. Refs #6793

Changeset: 59c7be485c5d26d09462a75276ac5d46d6115bff

comment:11 Changed 8 years ago by Andrei Savici

SetGoniometer small changes. Refs #6793

Changeset: 59c7be485c5d26d09462a75276ac5d46d6115bff

comment:12 Changed 8 years ago by Andrei Savici

  • Status changed from reopened to accepted

comment:13 Changed 8 years ago by Andrei Savici

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:14 Changed 8 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:15 Changed 8 years ago by Andrei Savici

Goniometer can take a number instead of log value. Refs #6793

Changeset: 2655fc449a7ecff2792dac9604c7e2f9cbc61152

comment:16 Changed 8 years ago by Andrei Savici

Change wiki section. Refs #6793

Changeset: 5dc9cf37bc898ebbb4beedd2d05ea55803e875b7

comment:17 Changed 8 years ago by Andrei Savici

SetGoniometer small changes. Refs #6793

Changeset: 59c7be485c5d26d09462a75276ac5d46d6115bff

comment:18 Changed 8 years ago by Peter Peterson

  • Status changed from verifying to closed

It works now.

comment:19 Changed 8 years ago by Andrei Savici

Goniometer can take a number instead of log value. Refs #6793

Changeset: 2655fc449a7ecff2792dac9604c7e2f9cbc61152

comment:20 Changed 8 years ago by Andrei Savici

Change wiki section. Refs #6793

Changeset: 5dc9cf37bc898ebbb4beedd2d05ea55803e875b7

comment:21 Changed 8 years ago by Andrei Savici

SetGoniometer small changes. Refs #6793

Changeset: 59c7be485c5d26d09462a75276ac5d46d6115bff

comment:22 Changed 7 years ago by Andrei Savici

Goniometer can take a number instead of log value. Refs #6793

Changeset: 2655fc449a7ecff2792dac9604c7e2f9cbc61152

comment:23 Changed 7 years ago by Andrei Savici

Change wiki section. Refs #6793

Changeset: 5dc9cf37bc898ebbb4beedd2d05ea55803e875b7

comment:24 Changed 7 years ago by Andrei Savici

SetGoniometer small changes. Refs #6793

Changeset: 59c7be485c5d26d09462a75276ac5d46d6115bff

comment:25 Changed 7 years ago by Andrei Savici

Goniometer can take a number instead of log value. Refs #6793

Changeset: 2655fc449a7ecff2792dac9604c7e2f9cbc61152

comment:26 Changed 7 years ago by Andrei Savici

Change wiki section. Refs #6793

Changeset: 5dc9cf37bc898ebbb4beedd2d05ea55803e875b7

comment:27 Changed 7 years ago by Andrei Savici

SetGoniometer small changes. Refs #6793

Changeset: 59c7be485c5d26d09462a75276ac5d46d6115bff

comment:28 Changed 7 years ago by Andrei Savici

Goniometer can take a number instead of log value. Refs #6793

Changeset: 2655fc449a7ecff2792dac9604c7e2f9cbc61152

comment:29 Changed 7 years ago by Andrei Savici

Change wiki section. Refs #6793

Changeset: 5dc9cf37bc898ebbb4beedd2d05ea55803e875b7

comment:30 Changed 7 years ago by Andrei Savici

SetGoniometer small changes. Refs #6793

Changeset: 59c7be485c5d26d09462a75276ac5d46d6115bff

comment:31 Changed 7 years ago by Andrei Savici

Goniometer can take a number instead of log value. Refs #6793

Changeset: 2655fc449a7ecff2792dac9604c7e2f9cbc61152

comment:32 Changed 7 years ago by Andrei Savici

Change wiki section. Refs #6793

Changeset: 5dc9cf37bc898ebbb4beedd2d05ea55803e875b7

comment:33 Changed 7 years ago by Andrei Savici

SetGoniometer small changes. Refs #6793

Changeset: 59c7be485c5d26d09462a75276ac5d46d6115bff

comment:34 Changed 7 years ago by Andrei Savici

Change wiki section. Refs #6793

Changeset: 5dc9cf37bc898ebbb4beedd2d05ea55803e875b7

comment:35 Changed 7 years ago by Andrei Savici

SetGoniometer small changes. Refs #6793

Changeset: 59c7be485c5d26d09462a75276ac5d46d6115bff

comment:36 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7639

Note: See TracTickets for help on using tickets.