Ticket #7166 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Cleanup HelpWindow code

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

HelpWindow would benefit from some re-organization of the code.

This was created while working on #7147.

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Peter Peterson

Re #7166. Rearranged HelpWindow code to make it clearer to read.

This includes changing order of code in start and making a method that returns the location of the qt-assistant executable.

Changeset: 114bcce6e44e7b8d462be043915f3e42a120b4d1

comment:3 Changed 7 years ago by Peter Peterson

Merge branch 'feature/7166_help_window_cleanup' into develop

comment:4 Changed 7 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

This was branched off of the ​v2.5.0 tag and is in the ​feature/7166_help_window_cleanup branch.

To test: look at the source code and see if it is more understandable.

comment:5 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:6 Changed 7 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/feature/7166_help_window_cleanup' into master

comment:7 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Agreed that it is more readable now.

comment:8 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8012

Note: See TracTickets for help on using tickets.