Ticket #7226 (closed: invalid)

Opened 7 years ago

Last modified 5 years ago

Make sure qtassistant target runs after everything is built

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Release 2.6
Component: Framework Keywords: qtassistant
Cc: petersonpf@… Blocked By:
Blocking: Tester: Peter Peterson

Description

We're getting spurious build failures at the moment because the qtassistant target comes in and leads to attempts to dlopen libraries that are being built at the same time. We need to force it to run after everything is built.

Ideally we'd exclude it from 'all' and hang it off the 'package' or 'install' targets but it seems that you can't mess with the pre-defined cmake targets so we'll probably just have to add more dependencies to the qtassistant target itself.

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Russell Taylor

Re #7226. Add additional dependencies to qtassistant target.

This should ensure that it is built after all shared libraries have been. (As this target actually runs Mantid there was a problem with it opening libraries that another parallel running target is building).

Changeset: 0a6af93ff85dfaf2d06fada20fa15343328bc932

comment:3 Changed 7 years ago by Russell Taylor

Merge branch 'feature/7226_qtassistant_build_order' into develop

Re #7226. Conflicts:

Code/Mantid/Framework/MDAlgorithms/src/ConvertToMD.cpp

Changeset: 37937bbab8572fa17b8146a6868854b8b1ea5d9f

comment:4 Changed 7 years ago by Russell Taylor

Re #7226. Cast the net wider.

Changeset: dcf21f224fbe8ecc1f34be3fa31a2d6d381cbfb6

comment:5 Changed 7 years ago by Russell Taylor

  • Cc petersonpf@… added
  • Status changed from accepted to verify
  • Resolution set to invalid

That didn't have any effect at all (see for example http://download.mantidproject.org/jenkins/job/is_inc_win7_develop/931 or https://builds.sns.gov/job/ornl_windows7_develop/661). Seems like this really does need to come right out of the all target somehow.

The branch is still there - do delete it on the verification step. This will disappear out of develop whenever it is next reset.

comment:6 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:7 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

I agree that Russell isn't fixing this. I've created #7245 to take an alternate approach.

comment:8 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8072

Note: See TracTickets for help on using tickets.