Ticket #7317 (closed: fixed)
Get the ISIS reflectometry Quick under test.
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.6 |
| Component: | Reflectometry | Keywords: | |
| Cc: | Blocked By: | #7319, #7472 | |
| Blocking: | #7502 | Tester: | Martyn Gigg |
Description (last modified by Owen Arnold) (diff)
Add automated testing for quick. Currently shipped as part of our scripts directory, as is used in the reflectometry GUI.
This is a necessary step on the reflectometry road map. Important for these reasons.
- Making further and safe improvements to the quick
- Allow us to catch anything that would break quick as early as possible
- Allow us to modify the Reflectometry gui code with confidence
Change History
comment:3 Changed 7 years ago by Owen Arnold
refs #7317. Move scripts out of package for testability.
Changeset: e6f500649cee5194502f1c2eeee47d9ba729ad04
comment:10 Changed 7 years ago by Owen Arnold
- Status changed from new to inprogress
- Description modified (diff)
comment:11 Changed 7 years ago by Owen Arnold
refs #7317. Create system test for quick script.
Changeset: af01e4557cb6c9d315a1159d69357dac388e04bb
comment:12 Changed 7 years ago by Owen Arnold
Tester: Check that this system test is passing on all environments based on the nightly clean builds.
comment:14 Changed 7 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
comment:15 Changed 7 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:16 Changed 7 years ago by Martyn Gigg
As discussed with Owen the commit in comment 3 got attached here bit looks like it was meant for #7319 which is already in master.
Here we will just test the system tests
comment:17 Changed 7 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7317_quick_systest'
comment:21 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8163
There are several ways that this problem could be approached, although I am loath to make any changes to quick (apart from perhaps its location) before I've got it fully under test. Putting an algorithm wrapper over the quick script might be a sensible way forward as it would fit nicely with our testing suite. Another way would be to adopt a system test approach first.