Ticket #7469 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Move ISIS SANS to Python API v2

Reported by: Mathieu Doucet Owned by: Martyn Gigg
Priority: major Milestone: Release 2.6
Component: Python Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

There are still a whole bunch of Python API v1 calls in the ISIS SANS code. They should be ported to API v2.

Change History

comment:1 Changed 7 years ago by Mathieu Doucet

Re #7469 moving some API v1 calls to API v2

Changeset: 8715990e561a8725c51eb27c42e4a67fcd2c6be6

comment:2 Changed 7 years ago by Martyn Gigg

  • Status changed from new to accepted
  • Owner set to Martyn Gigg

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from accepted to assigned

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:5 Changed 7 years ago by Martyn Gigg

  • Status changed from new to inprogress

Port reducer code to new Python API.

The ISIS SANS stuff still depends on it so we need to move it. Refs #7469

Changeset: 3d7ba07989203b7b060d53fb70c7ea61ac7ea751

comment:6 Changed 7 years ago by Martyn Gigg

Port EQSANSQ2DTest to new Python API Refs #7469

Changeset: 115f315bbb46f4252de5a556086a531d28cd0dd2

comment:7 Changed 7 years ago by Martyn Gigg

Move indirect diffraction reducer to new API.

It's not SANS but given that the base-class has to move too. Refs #7469

Changeset: 9969e5ba55f72c980373b6aea7dc70a4f04824d1

comment:8 Changed 7 years ago by Martyn Gigg

Remove restriction of mixing workspace types in GroupWorkspaces

The old code made it look like this was a restriction but it was not implemented correctly so you could group whatever you like. It really makes no sense anyway so simply remove the restriction. Refs #7469

Changeset: 3cd00e964b254149e5a8573edc93e6e61c117baa

comment:9 Changed 7 years ago by Martyn Gigg

Last commit was supposed to be against #7482.

comment:10 Changed 7 years ago by Martyn Gigg

Fix reducer modifications

Refs #7469

Changeset: c250240a814dad27c9b7f6e93281cb9207a0bdd1

comment:11 Changed 7 years ago by Mathieu Doucet

Re #7469 Adding back ORNL SANS API v1 tests during reducer porting

Changeset: 5dbdef80f6adb4522603624e8d05c524f2db01a3

comment:12 Changed 7 years ago by Martyn Gigg

Fix reducer passing properties to the algorithms. Refs #7469

Changeset: 94b0abc188b65eec44fb93fb4a7c98042e7b4089

comment:13 Changed 7 years ago by Martyn Gigg

Add Python exports to create AlgorithmProperty from Python.

Required to match behavour with old API. Refs #7469

Changeset: 570ec2fef5a34bda8659a4ed346bef560231f661

comment:14 Changed 7 years ago by Martyn Gigg

Fix algorithm returns in ported reducers. Refs #7469

Changeset: 033d971e080443dad6fad8a21602d46887df8bf7

comment:15 Changed 7 years ago by Martyn Gigg

Workaround for a places still wrapping std vectors. Refs #7469

Changeset: 63b01721f326360eebd5cbd548de9ec6e27034e6

comment:16 Changed 7 years ago by Martyn Gigg

Remove a couple of old invalid tests. Refs #7469

Changeset: 3f4eb47a4d141295058992da33c6aac96af7b886

comment:17 Changed 7 years ago by Martyn Gigg

Port reduction/instruments directory to new api. Refs #7469

Changeset: bfd1b1801ea425e0d723af8cefa97275251d95f2

comment:18 Changed 7 years ago by Martyn Gigg

Port inelastic reducer to v2 API. REfs #7469

Changeset: 9a54d5053c702b8e5d2f81b30f086ec8dbb062cf

comment:19 Changed 7 years ago by Martyn Gigg

Clear up final inelastic use of v1 API. Refs #7469

Changeset: 125494dc2116cd153ca1fbe27dfd774d656b1d07

comment:20 Changed 7 years ago by Martyn Gigg

Revert "Clear up final inelastic use of v1 API. Refs #7469"

This reverts commit 125494dc2116cd153ca1fbe27dfd774d656b1d07.

Turns out it has already been done somewhere else.

Changeset: cd299a5d672066c7c08e4fa2d60251d1260d57a5

comment:21 Changed 7 years ago by Martyn Gigg

Fix port of IndirectDiffractionReducer.

Refs #7469

Changeset: d24e93dd71310ab47b09df10edd203e133c98605

comment:22 Changed 7 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Branch: feature/7469_isis_sans_api2

Tester: This doesn't cover removing all of the old API but it should remove a very large fraction of the warnings in the system tests about using old api functionality. All of the system tests should still be passing at a minimum. The ISIS SANS interface in particular should be checked thoroughly.

comment:23 Changed 7 years ago by Gesner Passos

  • Status changed from verify to reopened
  • Resolution fixed deleted

I've tested the interface with many different inputs. Everything seems to work everything ok, but there is one single mention to old api:

instruments/sans/sans_reduction_steps.py:1176 if mtd.workspaceExists(output_ws)

comment:24 Changed 7 years ago by Martyn Gigg

  • Status changed from reopened to inprogress

Remove last reference to old API from sans_reduction_steps. Refs #7469

Changeset: e304c004302777623ec5903645eef3c71a6b35d1

comment:25 Changed 7 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Removed it so now it's ready to test again.

comment:26 Changed 7 years ago by Gesner Passos

  • Status changed from verify to closed

Merge remote-tracking branch 'origin/feature/7469_isis_sans_api2'

comment:27 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Python API

comment:28 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8314

Note: See TracTickets for help on using tickets.