Ticket #7736 (closed: fixed)
Expose MinimumPeakHeight to CalibrateRectangularDetectors
Reported by: | Peter Peterson | Owned by: | Peter Peterson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.0 |
Component: | Diffraction | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Wenduo Zhou |
Description (last modified by Peter Peterson) (diff)
This is a good way to filter out bad peaks that is already in the code, just not easily accessible to the user.
Also be more consistent on how things are returned from FindPeaks and GetDetOffsetMultiPeaks, how backgrounds are calculated, the d-range of interest for fitting, and clarify the FitInfo table (aka, little bit of code cleanup).
Change History
comment:2 Changed 7 years ago by Peter Peterson
- Status changed from new to inprogress
Re #7736. Consistently use the same code for bad fits.
Changeset: 8abc14005a282dbf5ce6bb949683d06babe0fd24
comment:3 Changed 7 years ago by Peter Peterson
Re #7736. Actually use the MinimumPeakHeight parameter.
It was passed into FindPeaks, but not checked again in GetDetOffsetsMultiPeaks. Also check for negative chisq being being returned.
Changeset: 851077b9ac5253b2f619fd142b9b230b48672512
comment:4 Changed 7 years ago by Peter Peterson
Re #7736. Exposing MinimumPeakHeight through py-algorithm.
Changeset: 6bf96aba53d9b4403a9ca077aeec971d30ba9e4b
comment:5 Changed 7 years ago by Peter Peterson
Re #7736. Refactored FindPeaks to simplify code (slightly).
This included:
- Only calculate the peak center once
- If the guessed peak width is < 1e-200 then don't bother fitting
- estimatePeakParameters just returns the error message if there is one.
Changeset: f9a03e37ddcfb2645c78637e71d4e5039ad45d3c
comment:6 Changed 7 years ago by Peter Peterson
Re #7736. Reduce the d-range that is used for finding peaks.
This is really just looking for where there is actual data (non-zero counts) and fitting that. There are also changes for reducing the number of uninteresting log messages.
Changeset: 14ba62cb9e107567dd8ecf760907dd34065ea63a
comment:7 Changed 7 years ago by Peter Peterson
Re #7736. Cleaned up information in InfoTableWorkspace
Changeset: 7b3f83aaa91e59d4f8ec1fb0c0d71193aca5034a
comment:8 Changed 7 years ago by Peter Peterson
Re #7736. Bringing all background estimations into one place
Changeset: 23312e4caefeed3686968e66ac4d4330e8f321e6
comment:9 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
This is on feature/7736_calibrate_pg3.
To test: The main feature to test is that you can still calibrate the instrument without specifying MinimumPeakHeight and that the FitInfoTable shows a lot less fitted peaks when you increase the number.
comment:10 Changed 7 years ago by Peter Peterson
- Status changed from verify to reopened
- Resolution fixed deleted
comment:11 Changed 7 years ago by Peter Peterson
- Status changed from reopened to inprogress
Re #7736. Updating golden results for PG3 calibration.
Changeset: e470736493e73ed33107e78ec9592067eab34bc8
comment:12 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
This is on mantid:feature/7736_calibrate_pg3 and systemtests:feature/7736_calibrate_pg3.
To test: The main feature to test is that you can still calibrate the instrument without specifying MinimumPeakHeight and that the FitInfoTable shows a lot less fitted peaks when you increase the number.
comment:13 Changed 7 years ago by Wenduo Zhou
- Status changed from verify to verifying
- Tester set to Wenduo Zhou
comment:14 Changed 7 years ago by Wenduo Zhou
By running the system test CalibrateRectangularDetector_Test with different MinimumPeakHeight, the number of peaks masked increases with higher minimum peak height. Ticket is thus close.
comment:15 Changed 7 years ago by Wenduo Zhou
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7736_calibrate_pg3'
comment:16 Changed 7 years ago by Martyn Gigg
Merge remote-tracking branch 'origin/feature/7736_calibrate_pg3'
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8581