Ticket #7759 (closed: fixed)
Correct mistake in Monitor type in various IDFs
| Reported by: | Mike Thomas | Owned by: | Mike Thomas |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Framework | Keywords: | |
| Cc: | michael.thomas@… | Blocked By: | |
| Blocking: | Tester: | Roman Tolchenov |
Description
The current monitor type definition reads: <!--MONITOR SHAPE--> <!--FIXME: Do something real here.-->
<type is="monitor" name="monitor">
<cylinder id="cyl-approx">
<centre-of-bottom-base y="0.0" x="0.0" z="0.0"/> <axis y="0.0" x="0.0" z="1.0"/> <radius radius="0.01"/> <height height="0.03"/>
</cylinder> <algebra val="cyl-approx"/>
</type>
Here 'radius' and 'height' are not valid attributes of <radius> and <height> respectively. These attributes should both be 'val'.
Suggested Correction:
<type is="monitor" name="monitor">
<cylinder id="cyl-approx">
<centre-of-bottom-base y="0.0" x="0.0" z="0.0"/> <axis y="0.0" x="0.0" z="1.0"/> <radius val="0.01"/> <height val="0.03"/>
</cylinder> <algebra val="cyl-approx"/>
</type>
Mistake occurs in the definitions of the following instruments: SANS, REF_M, REF_L, NOMAD, EQ-SANS, CNCS, BASIS, ARCS
Change History
comment:1 Changed 7 years ago by Anders Markvardsen
- Owner set to Anders Markvardsen
- Cc michael.thomas@… added; anders.markvardsen@… removed
comment:2 Changed 7 years ago by Mike Thomas
Full list of files with this attribute error: ARCS_Definition_19000000-20121010.xml ARCS_Definition_20121010-20121011.xml ARCS_Definition_20121011-.xml BASIS_Definition.xml CNCS_Definition_1-35154.xml CNCS_Definition_20120215-20120313.xml CNCS_Definition_20120314_20120816.xml CNCS_Definition_35155-44929.xml EQ-SANS_Definition.xml NOMAD_Definition.xml NOMAD_Definition_20120701-20120731.xml REF_L_Definition.xml REF_M_Definition.xml SANS_Definition.xml SEQUOIA_Definition.xml SEQUOIA_Definition_upto_19889.xml VISION_Definition.xml
comment:3 Changed 7 years ago by Mike Thomas
- Status changed from new to inprogress
Commit corrected IDFs Refs #7759
Changeset: 32189a547865055bae3ba692d89f48d805374e7d
comment:4 Changed 7 years ago by Anders Markvardsen
- Status changed from inprogress to verify
- Resolution set to fixed
To tester: changed accordign to description
comment:5 Changed 7 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:6 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7759_IDF_radius_attribute'
