Ticket #8289 (closed: fixed)
SNSLiveEventDataListener: Reduce a warning from error to debug
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 3.0 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: |
Description
In the testing of #8065 and subsequently, the log message at line 609 of SNSLiveEventDataListener has been observed:
g_log.error() << "run_number property already exists. Current value will be ignored." << std::endl
<< "(This should never happen. Talk to the Mantid developers.)" << std::endl;
I think that this can now appear if the listener is started outside a run, or there is a gap between runs. A run number of 0 will be entered if a RunStatus::STATE packet is encountered. The message will then be seen when a new run starts. This situation should be avoided with the fixing of #7209.
In the meantime, logging this message at error level is not helpful - it is really a very minor issue (the run number will be wrong inside the workspace) and having it appear may concern some users unnecessarily.
Change History
comment:2 Changed 7 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
To test: Just look at the code.
comment:3 Changed 7 years ago by Wenduo Zhou
- Status changed from verify to closed
Merge remote-tracking branch 'origin/feature/8289_snslivelistener_log_message'
Full changeset: d3bf2c87bd4d1e9ee147857c5c021a3ef1dec1c4
Re #8289. Reduce the level of a log message.
It seems this log message can now be triggered. However, it's really only a minor problem so don't let the (typical) user see it.
Changeset: ef5c80b8e1a4a8d9a9efaf4678da7addc0d22249