Ticket #9105 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

New MD normalization framework

Reported by: Andrei Savici Owned by: Andrei Savici
Priority: critical Milestone: Release 3.3
Component: Framework Keywords: SSC,2014,All
Cc: owen.arnold@…, Alex.Buts@… Blocked By: #9106, #9202, #10611, #10698, #10699, #10829
Blocking: Tester: Owen Arnold

Description

This is just a ticket to track the progress of work on the new MD normalization. The only commits on this ticket will be design documents, but it will be blocked by several smaller task, as we go along.

Change History

comment:1 Changed 7 years ago by Andrei Savici

  • Blocked By 9106 added

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 7 years ago by Andrei Savici

  • Status changed from assigned to inprogress

Progress on MD normalization presentation. Refs #9105

Changeset: 981cab97a4f0105bed4e84c243d6ac4b880b6e58

comment:4 Changed 7 years ago by Andrei Savici

  • Blocked By 9202 added

comment:5 Changed 6 years ago by Nick Draper

  • Keywords SSC added

comment:6 Changed 6 years ago by Alex Buts

  • Cc Alex.Buts@… added

comment:7 Changed 6 years ago by Andrei Savici

  • Blocked By 10611 added

comment:8 Changed 6 years ago by Nick Draper

Move all SSC tickets to critical by default

comment:9 Changed 6 years ago by Andrei Savici

  • Blocked By 10698 added

comment:10 Changed 6 years ago by Andrei Savici

  • Blocked By 10699 added

comment:11 Changed 6 years ago by Andrei Savici

comment:12 Changed 6 years ago by Andrei Savici

  • Blocked By 10829 added

comment:13 Changed 6 years ago by Andrei Savici

  • Blocked By 10829 removed

(In #10829) Normalization is calculated correctly for event workspaces only if the vent workspace is cropped and binned to the same interval. The normalization is using the limits from Rebin to calculate minimum and maximum final energy. However, if the event workspace is not cropped to the same interval, one might have MD events where the normalization is calculated to be 0. Maybe ConvertToMD for events should automatically ignore the events that fall outside the binning range.

Not too much to test. Check if the explanation makes sense, maybe play with the usage example. A note about same limits for cropping and binning should be in the help file.

comment:14 Changed 6 years ago by Andrei Savici

  • Blocked By 10829 added

comment:15 Changed 6 years ago by Andrei Savici

MD normalization documentation. Refs #9105

Changeset: 02c1adb5bda72331f7d8aca1f79abeed6dcc4d77

comment:16 Changed 6 years ago by Andrei Savici

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:17 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:18 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9105_MDNorm_concept'

Full changeset: cb39e212d9b8ae7ba2c214e40ed22cf1c737fec7

comment:19 Changed 6 years ago by Owen Arnold

All blocked tickets of this umbrella one are completed. I'll separately send you some comments and a patch commit for your documentation to apply later.

comment:20 Changed 6 years ago by Nick Draper

  • Keywords SSC,2014,All added; SSC removed

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9948

Note: See TracTickets for help on using tickets.