Ticket #5161 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Create separate algorithm which would preprocess detectors

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 2.3
Component: VATES Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

The algorithm should take/return table workspace for convenient verification/modification/managment

Change History

comment:1 Changed 8 years ago by Alex Buts

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Alex Buts

refs #5161 Preprocessed detectors are now separate class

Changeset: 45fc52948d36c3ff7af6d9eacb7b9969d707b584

comment:3 Changed 8 years ago by Alex Buts

refs #5161 detectors clear behind themselves

refs #4401 a performance test skeleton

Changeset: 81dba05c570df4019b206ee7920f73cf426cd935

comment:4 Changed 8 years ago by Alex Buts

refs #5161 Class properly clears behind themselves

Changeset: 5cf41fef28161ccc759715209dd82e46384ca3a4

comment:5 Changed 8 years ago by Alex Buts

refs #5161 Preprocessed detectors are now separate class

Changeset: 45fc52948d36c3ff7af6d9eacb7b9969d707b584

comment:6 Changed 8 years ago by Alex Buts

refs #5161 detectors clear behind themselves

refs #4401 a performance test skeleton

Changeset: 81dba05c570df4019b206ee7920f73cf426cd935

comment:7 Changed 8 years ago by Alex Buts

refs #5161 Class properly clears behind themselves

Changeset: 5cf41fef28161ccc759715209dd82e46384ca3a4

comment:8 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:9 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:10 Changed 8 years ago by Alex Buts

In addition, the algorithm should have possibility to return min/max values of coordinates in Q-space (or any space generated by selected conversion generated by MD conversion factory assuming that the transformation is homogeneous)

comment:11 Changed 8 years ago by Alex Buts

refs #5161 First steps in creating new algorithm

But this causes unexpected changes in ITableWorkspace.h and children

Changeset: 56afc230ec4f703887e03b7e4f0342944de85ea1

comment:12 Changed 8 years ago by Alex Buts

refs #5161 Small changes necessary for further work.

And hopefully get rid of annoying "inherited via dominance" messages.

Changeset: faac944235980a55e15431db085a8e9e7f782bd4

comment:13 Changed 8 years ago by Alex Buts

refs #5161 Fixing Unix warning(error)

Changeset: 518d9b645238e3093045e3e1f74444b5693f978d

comment:14 Changed 8 years ago by Alex Buts

refs #5161 Intermediate step

Changeset: 0daac393ff4cb727dddb1d66799c751634a4b0cb

comment:15 Changed 8 years ago by Alex Buts

refs #5161 Main body of the algorithm

Changeset: a43577aa787f3c8fdce0fc48429fa27f2930a0a0

comment:16 Changed 8 years ago by Alex Buts

refs #5161 Initial working version of the algorithm

Changeset: 6bb8855b9fa4be27e13b696f5277e47d223a11b8

comment:17 Changed 8 years ago by Alex Buts

refs #5161 Fixing Unix cast error

Changeset: 71c623bf905fffe3740341320c98036cb6c7e1d0

comment:18 Changed 8 years ago by Alex Buts

refs #5161 fixing Unix error

Changeset: 2e9a043ccbdf4097459dcdcc77c2f60995081872

comment:19 Changed 8 years ago by Alex Buts

refs #5161 fixing Unix warnings.

Changeset: 33c8d37e27ba7669ea0c4d617941ef757764c3ea

comment:20 Changed 8 years ago by Alex Buts

refs #5161 All main functionality is in the algorithm.

Changeset: 694534e853f1d6ddff52a5fe518f4408366fa9dd

comment:21 Changed 8 years ago by Alex Buts

refs #5161 Test for faked detectors

Changeset: c93d26f0734133d7564fbb7fa52da09738fa34dc

comment:22 Changed 8 years ago by Alex Buts

refs #5161 PreprocessDetectorsToMD tested

Changeset: 9dfdf512b348cd622bdd099498b62cfd54bc8c61

comment:23 Changed 8 years ago by Alex Buts

refs #5161 All done and compiles (but not tested)

Changeset: 34beb3171822f4918ffba846097e62c9853bbaee

comment:24 Changed 8 years ago by Alex Buts

refs #5161 Now it compiles

Changeset: ba61ec181091027615cfc78191bdc7f98c6bf819

comment:25 Changed 8 years ago by Alex Buts

refs #5161 fixing unit tests

Changeset: 442a043f132b53303159f690aa6f0b3bd1b09d87

comment:26 Changed 8 years ago by Alex Buts

refs #5161 Fixing more tests

Changeset: 75afe738d96d7711c591ca54e09e65a060c100e8

comment:27 Changed 8 years ago by Alex Buts

refs #5161 fixing warning and missed test

Changeset: 5a082cea694553fd551fa282c591fe7ddfcf0b75

comment:28 Changed 8 years ago by Alex Buts

refs #5161 fixing stupid error

Changeset: 3fcb89beefc9f94f0652d75b8fa7d3c050d0f8c8

comment:29 Changed 8 years ago by Alex Buts

refs #5161 Wiki information.

Changeset: f5723976f5d7bfab9f45ba73d1df6612cdbd2835

comment:30 Changed 8 years ago by Alex Buts

refs #5161 Minor changes to Wiki

Changeset: 84a8f3e2ade726cad4c910c92855fde70e1e9194

comment:31 Changed 8 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

PreprocessDetectorsToMD? algorithm is written, works with ConvertToMD and available in Wiki. No changes should exist in ConvertToMD results, but the algorithm and its results are the basis for future development, e.g. calculating min-max values in Q-space and processing detectors trajectories.

Separate ticket #5875 is written for calculate min-max values.

comment:32 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:33 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

Works. On Direct geometry data, eFixed is returned as nans

comment:34 Changed 8 years ago by Alex Buts

refs #5161 First steps in creating new algorithm

But this causes unexpected changes in ITableWorkspace.h and children

Changeset: 56afc230ec4f703887e03b7e4f0342944de85ea1

comment:35 Changed 8 years ago by Alex Buts

refs #5161 Small changes necessary for further work.

And hopefully get rid of annoying "inherited via dominance" messages.

Changeset: faac944235980a55e15431db085a8e9e7f782bd4

comment:36 Changed 8 years ago by Alex Buts

refs #5161 Fixing Unix warning(error)

Changeset: 518d9b645238e3093045e3e1f74444b5693f978d

comment:37 Changed 8 years ago by Alex Buts

refs #5161 Intermediate step

Changeset: 0daac393ff4cb727dddb1d66799c751634a4b0cb

comment:38 Changed 8 years ago by Alex Buts

refs #5161 Main body of the algorithm

Changeset: a43577aa787f3c8fdce0fc48429fa27f2930a0a0

comment:39 Changed 8 years ago by Alex Buts

refs #5161 Initial working version of the algorithm

Changeset: 6bb8855b9fa4be27e13b696f5277e47d223a11b8

comment:40 Changed 8 years ago by Alex Buts

refs #5161 Fixing Unix cast error

Changeset: 71c623bf905fffe3740341320c98036cb6c7e1d0

comment:41 Changed 8 years ago by Alex Buts

refs #5161 fixing Unix error

Changeset: 2e9a043ccbdf4097459dcdcc77c2f60995081872

comment:42 Changed 8 years ago by Alex Buts

refs #5161 fixing Unix warnings.

Changeset: 33c8d37e27ba7669ea0c4d617941ef757764c3ea

comment:43 Changed 8 years ago by Alex Buts

refs #5161 All main functionality is in the algorithm.

Changeset: 694534e853f1d6ddff52a5fe518f4408366fa9dd

comment:44 Changed 8 years ago by Alex Buts

refs #5161 Test for faked detectors

Changeset: c93d26f0734133d7564fbb7fa52da09738fa34dc

comment:45 Changed 8 years ago by Alex Buts

refs #5161 PreprocessDetectorsToMD tested

Changeset: 9dfdf512b348cd622bdd099498b62cfd54bc8c61

comment:46 Changed 8 years ago by Alex Buts

refs #5161 All done and compiles (but not tested)

Changeset: 34beb3171822f4918ffba846097e62c9853bbaee

comment:47 Changed 8 years ago by Alex Buts

refs #5161 Now it compiles

Changeset: ba61ec181091027615cfc78191bdc7f98c6bf819

comment:48 Changed 8 years ago by Alex Buts

refs #5161 fixing unit tests

Changeset: 442a043f132b53303159f690aa6f0b3bd1b09d87

comment:49 Changed 8 years ago by Alex Buts

refs #5161 Fixing more tests

Changeset: 75afe738d96d7711c591ca54e09e65a060c100e8

comment:50 Changed 8 years ago by Alex Buts

refs #5161 fixing warning and missed test

Changeset: 5a082cea694553fd551fa282c591fe7ddfcf0b75

comment:51 Changed 8 years ago by Alex Buts

refs #5161 fixing stupid error

Changeset: 3fcb89beefc9f94f0652d75b8fa7d3c050d0f8c8

comment:52 Changed 8 years ago by Alex Buts

refs #5161 Wiki information.

Changeset: f5723976f5d7bfab9f45ba73d1df6612cdbd2835

comment:53 Changed 8 years ago by Alex Buts

refs #5161 Minor changes to Wiki

Changeset: 84a8f3e2ade726cad4c910c92855fde70e1e9194

comment:54 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 6007

Note: See TracTickets for help on using tickets.