Update Reflectometry GUI

[Owen Arnold]

Max has update the scripts behind his GUI, and needs these updating

We are about to start a process of managing these scripts ourself, and subjecting them to automatic testing, so this will probably be the last time we accept the script updates verbatim.

[Owen Arnold]

Need to get an updated INTER IDF from Max before this work can proceed.

[Owen Arnold]

refs #7372. Update system tests.

Changeset: c7f5ac2425f41070cd385cebd35d4e6f1428b2f5

[Owen Arnold]

refs #7372. Add updated script files.

Changeset: d8fe81d15296ad1dc07a4671a68446a76526b2c0

[Owen Arnold]

refs #7372. Move to new version of python API.

Changeset: 7ad053750e66779310ec0b89598be05340dc75fd

[Owen Arnold]

Will need to re-merge from master before continuing with this. I'm also going to add the other tickets pending testing as blockers to this.

[Owen Arnold]

This should be fine to do now.

[Owen Arnold]

refs #7372. Add updated script files.

Changeset: 4dd634ae2877eff8c4b8a06eacdd5c51eda6c32a

[Owen Arnold]

refs #7372. Move to new version of python API.

Changeset: 53662000256a761603b748bfd2727046306e84a4

[Owen Arnold]

refs #7372. Further migration work to v2 of python API

Things appear to be running the same in this gui+script as they were in the old gui+script. I've done a little refactoring work, but the bulk of the refactoring work will have to wait, as there are many violations.

Changeset: 4bfe2c13f753035845f177e1858b200823046a50

[Owen Arnold]

Test data + script

[Owen Arnold]

Tester:

Install version 2.5 or 2.5.3 of Mantid and also build this branch. Also, Unpack the attached compressed file.

Starting with the old version of Mantid, follow this procedure.

• Start up MantidPlot and select Interfaces -> ISIS Reflectometry
• Add the unpacked directory location to your managed user directories
• From the drop down on the reflectometry interface, set the instrument to INTER
• From the File menu in the reflectometry interface, load the *.tbl file (also in the unpacked directory)
• Click the 'Process button' and hit 'Delete' if prompted in the GUI (this is a bug to be fixed later)
• You should end up with two plots both with momentum transfer on the x-axis

Without closing the current open version of mantidplot (the older one), start up MantidPlot built from this branch. Follow exactly the same procedure again, and you should get near-identical plots generated. You can compare the plots visually between the two versions of MantidPlot.

On both the old and the new interfaces, there are selectable options for 'stitching'. Click these and re-run. Again, compare the plots.

Tester, I'll also be running these interfaces by the Reflectometry user group at ISIS, and they were the ones who provided the changes, so providing the interfaces are running without generating any python errors, owing to the migration, our job on this ticket is done. Scientific validation of the output can be provided by the Reflectometry group.

[Nick Draper]

Functionality is Passed, but if the Delete action is being sorted on another ticket then please specify the ticket number. also the window title is MainWindow.

[Owen Arnold]

Annoying Delete issue has been documented and assigned in #7466.

[Owen Arnold]

refs #7372. Give the GUI a proper name.

This is a bit hackey, because Max has lost the original *.ui file, and clearly that would be the best place to fix it. However, it's going to be a semi-major operation to reverse-engineer the ui file out of this generated file. We do plan to do it at some point.

Changeset: d843acc2217d08303a1b5d56d5badfe28324eee5

[Nick Draper]

Merge remote-tracking branch 'origin/feature/7372_new_gui_code'

[Nick Draper]

As earlier functional test passed, the remaining checks have passed by code review

[Stuart Campbell]

This ticket has been transferred to github issue ​8218